Re: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Chris,

On Thu, Jul 26, 2018 at 2:25 PM Chris Brandt <Chris.Brandt@renesas.com> wrote:
> On Thursday, July 26, 2018, Geert Uytterhoeven wrote:
> > Thanks for your series!
> >
> > Unfortunately Greg has already applied your v1 (and my fix for a
> > use-after-free), so either these have to be reverted first, or you have to
> > rebase against tty-next.
>
> I assume you would prefer the newer implementation I did.
>
> In your opinion, which one would be better (revert or rebase)?

[looking at the incremental differences]

I think the easiest for Greg is to rebase, and send 3 patches:
  1. Document interrupt order in bindings,
  2. Unify SCIx_RZ_SCIFA_REGTYPE/SCIx_SH4_SCIF_REGTYPE regtypes,
  3. Simplify interrupts.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds