Re: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Clément,

On Wed, Feb 15, 2023 at 12:31 PM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Wed, Feb 15, 2023 at 11:52 AM Clément Léger
> <clement.leger@bootlin.com> wrote:
> > Le Wed, 15 Feb 2023 09:29:33 +0100,
> > Clément Léger <clement.leger@bootlin.com> a écrit :
> > > Le Tue, 14 Feb 2023 17:25:14 +0100,
> > > Geert Uytterhoeven <geert@linux-m68k.org> a écrit :
> > > > On Thu, Feb 9, 2023 at 2:32 PM Clément Léger <clement.leger@bootlin.com> wrote:
> > > > > The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this
> > > > > configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb.
> > > > > It adds support for the 2 additional switch ports (port C and D) that are
> > > > > available on that board.
> > > > >
> > > > > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> > > >
> > > > Thanks for your patch!
> > > >
> > > > > --- /dev/null
> > > > > +++ b/arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts
>
> > > > > +       pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>,
> > > > > +                   <&pins_mdio1>;
> > > > > +
> > > > > +       mdio {
> > > > > +               /* CN15 and CN16 switches must be configured in MDIO2 mode */
> > > > > +               switch0phy1: ethernet-phy@1 {
> > > > > +                       reg = <1>;
> > > > > +                       marvell,reg-init = <3 16 0 0x1010>;
> > > >
> > > > marvell,reg-init is not documented in any DT bindings document?
> > >
> > > Indeed, this is not somethiong that should be made available here. It's
> > > only inverting the LED polarity but supported by some internal patch.
> > > I'll remove that.
>
> > I actually was confused by a property I added in another device-tree but
> > marvell,reg-init exists, is handled by the marvell phy driver and used
> > in a few device-trees. Strangely, it is not documented anywhere. So I
> > can either remove that (and the LED won't work properly) or let it live
> > depending on what you prefer.
>
> In that case, please keep it.
> But the property really should be documented, one day...

Any plans to follow-up?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds