From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 1/4] thermal: rcar_gen3_thermal: Document the R-Car Gen3 thermal bindings Date: Mon, 20 Jun 2016 09:49:38 +0200 Message-ID: References: <57661211.7010900@rvc.renesas.com> <57661290.9000501@rvc.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <57661290.9000501-NdPGGYSbX7otW8iMtHSHnA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Khiem Nguyen Cc: Kuninori Morimoto , Wolfram Sang , Geert Uytterhoeven , Magnus Damm , Zhang Rui , Eduardo Valentin , Rob Herring , Mark Rutland , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Thao Phuong Le. Nguyen" , "Hien Duy. Dang" , Toru Oishi List-Id: devicetree@vger.kernel.org Hi Khiem, On Sun, Jun 19, 2016 at 5:33 AM, Khiem Nguyen wrote: > > Signed-off-by: Hien Dang > Signed-off-by: Khiem Nguyen Thanks for your patch! > --- > .../bindings/thermal/rcar-gen3-thermal.txt | 79 ++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt > new file mode 100644 > index 0000000..ed6ce45 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt > @@ -0,0 +1,79 @@ > +* DT bindings for Renesas R-Car Gen3 Thermal Sensor driver > + > +Required properties: > +- compatible : "renesas,thermal-", Please use "renesas,-thermal", as this is the preferred order for new bindings. > + Examples with soctypes are: > + - "renesas,thermal-r8a7795" (R-Car H3) renesas,r8a7795-thermal > + - "renesas,thermal-r8a7796" (R-Car M3) renesas,r8a7796-thermal, M3-W > + - "renesas,rcar-gen3-thermal" as fallback > +- reg : Address range of the thermal registers. > +- clocks : Must contain a reference to the functional clock. According to the datasheet, the USB_EXTAL clock is also an input for the thermal block. Should it be added? > +- #thermal-sensor-cells : Please see ./thermal.txt > + > +Option properties: Optional > + > +- interrupts : Use interrupt > +- power-domain : Must contain a reference to the power domain. This property is > + mandatory if the thermal sensor instance is part of a controllable power > + domain. > + > +Example (non interrupt support): Is there a good reason why you wouldn't want to use interrupts? If not, please make it mandatory. > + > + tsc1: thermal@e6198000 { > + compatible = "renesas,thermal-r8a7795", > + "renesas,rcar-gen3-thermal"; > + reg = <0 0xe6198000 0 0x5c>; According to the datasheet, there are more registers beyond this range. Shouldn't it be "reg = <0 0xe6198000 0 0x68>;"? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html