* [PATCH] arm64: dts: renesas: hihope-common: Fix EXTAL Clock frequency
@ 2019-12-18 11:13 Biju Das
2019-12-20 16:04 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Biju Das @ 2019-12-18 11:13 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, Chris Paterson,
Marian-Cristian Rotariu, Simon Horman, linux-renesas-soc,
devicetree, Simon Horman, Fabrizio Castro
As per the schematic, the extal frequency is 16.6666MHz. However
it is wrongly mentioned as 16666666 on the SoC dtsi.
Fixes: 438419ebd3f86221390 ("arm64: dts: renesas: Add HiHope RZ/G2M
main board support")
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/hihope-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
index 2c942a7..88e6aa9 100644
--- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
@@ -154,7 +154,7 @@
};
&extal_clk {
- clock-frequency = <16666666>;
+ clock-frequency = <16666600>;
};
&extalr_clk {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: renesas: hihope-common: Fix EXTAL Clock frequency
2019-12-18 11:13 [PATCH] arm64: dts: renesas: hihope-common: Fix EXTAL Clock frequency Biju Das
@ 2019-12-20 16:04 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-12-20 16:04 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Geert Uytterhoeven, Magnus Damm,
Chris Paterson, Marian-Cristian Rotariu, Simon Horman,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Simon Horman, Fabrizio Castro
Hi Biju,
On Wed, Dec 18, 2019 at 12:15 PM Biju Das <biju.das@bp.renesas.com> wrote:
> As per the schematic, the extal frequency is 16.6666MHz. However
> it is wrongly mentioned as 16666666 on the SoC dtsi.
>
> Fixes: 438419ebd3f86221390 ("arm64: dts: renesas: Add HiHope RZ/G2M
> main board support")
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> @@ -154,7 +154,7 @@
> };
>
> &extal_clk {
> - clock-frequency = <16666666>;
> + clock-frequency = <16666600>;
> };
Given the schematics say the accuracy of the part is specified as 50ppm[*],
changing this doesn't matter much, IMHO.
[*] Yeah, that's more than 4s/day, so it would made a lousy watch, if not
for NTP ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-20 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-18 11:13 [PATCH] arm64: dts: renesas: hihope-common: Fix EXTAL Clock frequency Biju Das
2019-12-20 16:04 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).