From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF74B79CD for ; Mon, 18 Sep 2023 12:08:00 +0000 (UTC) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5516A9; Mon, 18 Sep 2023 05:07:59 -0700 (PDT) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-59c0b5f984aso31684307b3.2; Mon, 18 Sep 2023 05:07:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695038878; x=1695643678; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qVLFaUZxjITE8rsgw+msJqGq4oa1CVCEEZAwZaJky7Y=; b=Sd51PttW5gIDKNCE/2gQSnJa+93uju8mGp7tF8VNScoozQnI9Ro1VF0PzFprXM40c/ Xjja1uXQxdkpFJiUCNada+qRWnVh6208LT1oftwdp12mXJ+eLECLu0Yq1rPvTZVsjgsX DOUzRppZtbfXJAulnCNCO9xHx/16h6/vOk4uZPMttGNiNpFZeBwZEgWB97f4qdZaSu4+ eyNbTzYyuS81dkOYem5dgOsXAW0WMBWhi492lLegGTdxES/oFAz/LyuEkcNA1bOry29r SsG/Fd1lcnkBILrL0nw55w1FTu1YbQSNLDH/gR+/DswUeH/2e0zleHlz2Ap5KZEl+lP3 pgkw== X-Gm-Message-State: AOJu0YxXF2wsszg15NslO2SnBOwFmdxHEkLlBgruqkCFmydlmLQdmdvN K0Drv7ifRhnclsIr5B05tBJS82M25JVX2w== X-Google-Smtp-Source: AGHT+IFek3kqpUOJnGFMwvatm/fLTMWJsD34hLXKaBKav8ilU/6R+d5yvUQStlnEpVmpXIjn9nE4Yw== X-Received: by 2002:a81:ee0e:0:b0:59b:4bb2:fc2c with SMTP id l14-20020a81ee0e000000b0059b4bb2fc2cmr160497ywm.48.1695038878327; Mon, 18 Sep 2023 05:07:58 -0700 (PDT) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com. [209.85.128.180]) by smtp.gmail.com with ESMTPSA id d194-20020a814fcb000000b0058fb9863fe7sm2485229ywb.103.2023.09.18.05.07.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 05:07:58 -0700 (PDT) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-59be6605e1dso47396927b3.3; Mon, 18 Sep 2023 05:07:58 -0700 (PDT) X-Received: by 2002:a81:8287:0:b0:59c:7d0:ab06 with SMTP id s129-20020a818287000000b0059c07d0ab06mr9944623ywf.45.1695038877926; Mon, 18 Sep 2023 05:07:57 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230911214623.2201324-1-robh@kernel.org> In-Reply-To: <20230911214623.2201324-1-robh@kernel.org> From: Geert Uytterhoeven Date: Mon, 18 Sep 2023 14:07:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: renesas: Apply overlays to base dtbs To: Rob Herring Cc: Magnus Damm , Krzysztof Kozlowski , Conor Dooley , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi Rob, On Mon, Sep 11, 2023 at 11:47=E2=80=AFPM Rob Herring wrot= e: > DT overlays in tree need to be applied to a base DTB to validate they > apply, to run schema checks on them, and to catch any errors at compile > time. > > Signed-off-by: Rob Herring Thanks for your patch! > Looks like some of these apply to multiple base DTs. I've only added them > to 1 base. Indeed: - draak-ebisu-panel-aa104xd12.dtbo applies to r8a77990-ebisu.dtb, too, - salvator-panel-aa104xd12.dtbo applies to all salvator-x(s) variants. So should they be added to all bases they apply to? Or, if you intend none of the composite DTBs to be consumed as-is, but only intend them to be created for validation, perhaps the additional rules should be grouped together at the bottom of the Makefile? > --- a/arch/arm64/boot/dts/renesas/Makefile > +++ b/arch/arm64/boot/dts/renesas/Makefile > @@ -64,6 +65,8 @@ dtb-$(CONFIG_ARCH_R8A779F0) +=3D r8a779f0-spider.dtb > > dtb-$(CONFIG_ARCH_R8A779G0) +=3D r8a779g0-white-hawk.dtb > dtb-$(CONFIG_ARCH_R8A779G0) +=3D r8a779g0-white-hawk-ard-audio-da7212.dt= bo Do you still need the individual *.dtbo rules? Perhaps you are afraid that make will auto-delete them as they are only used as intermediaries? > +r8a779g0-white-hawk-ard-audio-da7212-dtbs :=3D r8a779g0-white-hawk.dtb r= 8a779g0-white-hawk-ard-audio-da7212.dtbo > +dtb-$(CONFIG_ARCH_R8A779G0) +=3D r8a779g0-white-hawk-ard-audio-da7212.dt= b Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds