From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-clk <linux-clk@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Fix clock[-name]s properties
Date: Thu, 24 Oct 2019 13:45:45 +0200 [thread overview]
Message-ID: <CAMuHMdXLOh3j-CFb3008DkXVAmq2MWCSW0SqzPoBBeq5v1qwoA@mail.gmail.com> (raw)
In-Reply-To: <1571915821-1620-2-git-send-email-yoshihiro.shimoda.uh@renesas.com>
Hi Shimoda-san,
On Thu, Oct 24, 2019 at 1:17 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Since the hardware requires to enable both USB 2.0 host and peripheral
> functional clock, this patch fixes the documentation.
> Fortunately, no one has this device node for now, so that we don't
> need to think of backward compatibility.
>
> Fixes: 311accb64570 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Thanks four your patch!
Looks good to me, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
I'm just wondering about the inconsistent use of "_" and "-" in clock
names, but I don't have a better suggestion ("hs-usb-if", "usb_extal",
and "usb_xtal" do match the datasheet), so let's ignore my OCD ;-)
> --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> @@ -38,7 +38,8 @@ Required properties:
> - reg: offset and length of the USB 2.0 clock selector register block.
> - clocks: A list of phandles and specifier pairs.
> - clock-names: Name of the clocks.
> - - The functional clock must be "ehci_ohci"
> + - The functional clock of USB 2.0 host side must be "ehci_ohci"
"_" means "and".
> + - The functional clock of HS-USB side must be "hs-usb-if"
"-" means concatenation of terms.
> - The USB_EXTAL clock pin must be "usb_extal"
> - The USB_XTAL clock pin must be "usb_xtal"
"_" means concatenation of terms.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-10-24 11:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 11:16 [PATCH 0/3] clk: renesas: rcar-usb2-clock-sel: Fix clks/resets handling Yoshihiro Shimoda
2019-10-24 11:16 ` [PATCH 1/3] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Fix clock[-name]s properties Yoshihiro Shimoda
2019-10-24 11:45 ` Geert Uytterhoeven [this message]
2019-10-25 1:29 ` Yoshihiro Shimoda
2019-10-25 7:45 ` Geert Uytterhoeven
2019-10-24 11:17 ` [PATCH 2/3] clk: renesas: rcar-usb2-clock-sel: Add multiple clocks management Yoshihiro Shimoda
2019-10-24 11:34 ` Geert Uytterhoeven
2019-10-25 1:36 ` Yoshihiro Shimoda
2019-10-25 7:47 ` Geert Uytterhoeven
2019-10-25 8:44 ` Yoshihiro Shimoda
2019-10-25 8:57 ` Geert Uytterhoeven
2019-10-24 11:17 ` [PATCH 3/3] clk: renesas: rcar-usb2-clock-sel: Add reset_control Yoshihiro Shimoda
2019-10-24 11:26 ` Geert Uytterhoeven
2019-10-25 1:42 ` Yoshihiro Shimoda
2019-10-25 7:54 ` Geert Uytterhoeven
2019-10-25 8:44 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXLOh3j-CFb3008DkXVAmq2MWCSW0SqzPoBBeq5v1qwoA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).