devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
To: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
Cc: Sergei Shtylyov
	<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Kuninori Morimoto
	<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
	Yoshihiro Shimoda
	<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	USB list <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux-sh list <linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings
Date: Tue, 15 Dec 2015 12:00:17 +0100	[thread overview]
Message-ID: <CAMuHMdXMB4nsbaT8vo_sOd8mzSABLyk3+_sPHnm2q_p7vR-qHA@mail.gmail.com> (raw)
In-Reply-To: <20151215064134.GA29842-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>

On Tue, Dec 15, 2015 at 7:41 AM, Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> wrote:
>> >diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> >index a14c0bb561d5..c55cf77006d0 100644
>> >--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> >+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> >@@ -2,10 +2,18 @@ Renesas Electronics USBHS driver
>> >
>> >  Required properties:
>> >    - compatible: Must contain one of the following:
>>
>>    Really?
>
> Would "...one or more of the following" help?

+1

>> >+
>> >     - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
>> >     - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
>> >     - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
>> >     - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
>> >+    - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
>> >+    - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
>> >+
>> >+    When compatible with the generic version, nodes must list the
>> >+    SoC-specific version corresponding to the platform first followed
>> >+    by the generic version.
>> >+
>>
>>    This kinda contradicts the above claim.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-12-15 11:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  2:12 [PATCH v3 0/3] usb: renesas_usbhs: More compat strings Simon Horman
2015-12-11  2:12 ` [PATCH v3 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation Simon Horman
2015-12-11  3:54   ` Rob Herring
     [not found] ` <1449799947-19866-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-11  2:12   ` [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings Simon Horman
2015-12-11  3:56     ` Rob Herring
2015-12-11  4:02       ` Simon Horman
2015-12-11 12:24     ` Sergei Shtylyov
     [not found]       ` <566AC07B.6060201-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-12-15  6:41         ` Simon Horman
     [not found]           ` <20151215064134.GA29842-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-15 11:00             ` Geert Uytterhoeven [this message]
2015-12-15 11:33           ` Sergei Shtylyov
2015-12-11  2:12   ` [PATCH v3 3/3] usb: renesas_usbhs: add device tree support for r8a779[23] Simon Horman
2015-12-11  2:58 ` [PATCH v3 0/3] usb: renesas_usbhs: More compat strings Kuninori Morimoto
2015-12-16 16:23 ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdXMB4nsbaT8vo_sOd8mzSABLyk3+_sPHnm2q_p7vR-qHA@mail.gmail.com \
    --to=geert-td1emuhucqxl1znqvxdv9g@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
    --cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
    --cc=yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).