From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD075C433EF for ; Tue, 12 Apr 2022 10:09:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354663AbiDLKHg (ORCPT ); Tue, 12 Apr 2022 06:07:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385668AbiDLIw2 (ORCPT ); Tue, 12 Apr 2022 04:52:28 -0400 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7176764710; Tue, 12 Apr 2022 01:12:55 -0700 (PDT) Received: by mail-qk1-f174.google.com with SMTP id d71so4989105qkg.12; Tue, 12 Apr 2022 01:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZnqEEZ1zFWnMJmtyNXblrY5MQvtZ5RBg/IUnGVTe7nE=; b=FaAqLTPeR8zQW28ZYZCMsxHJuewq63COHX12yxCzeSPASMWiVkxApRM3Q3N9L+L4gq SwzrLNp28g8Fza8b7iA+Bn806a+TLVhbGXjg3G3nFx1qgsUVaLdyMT962s8VxEpvMgpV SuX5jB4EGecuEgxRLSVOjIgbzaO85PELkhf9gx8d9We0r15ZopzQxn6RpcipRcYZggek sFr+ZYnsgu9W2jkkBhPYaasyV4a/6H7uRSt1oza4W4q+LHlDE0JDLuT67NtRSeiRT6KT AN1qgmi9qBQfCayw1HNgK08q+k+nq+lJ72v8TAvVFM4DghVj8v3GOssu3pxP4uijJwjz ZuSA== X-Gm-Message-State: AOAM5311HGp/B+P25j7ipmDN3k7bSZL578NQ/EmMqkJpotTwPBbMD+YF e/jtqM4spaOz2upd1PUWuLR4vffv/g8R4hXt X-Google-Smtp-Source: ABdhPJyRBsmcscwkqiImLbeE05pXeu7rnAt4FYsRfXBmLtITfkTGWrMy+PSIdz+V0vv2MKO7WXgsJQ== X-Received: by 2002:a37:a897:0:b0:69c:329:2310 with SMTP id r145-20020a37a897000000b0069c03292310mr2241446qke.349.1649751174055; Tue, 12 Apr 2022 01:12:54 -0700 (PDT) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com. [209.85.219.172]) by smtp.gmail.com with ESMTPSA id e15-20020ac8670f000000b002e22d9c756dsm23923536qtp.30.2022.04.12.01.12.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 01:12:53 -0700 (PDT) Received: by mail-yb1-f172.google.com with SMTP id p65so13523245ybp.9; Tue, 12 Apr 2022 01:12:53 -0700 (PDT) X-Received: by 2002:a25:2c89:0:b0:641:2884:b52e with SMTP id s131-20020a252c89000000b006412884b52emr9459376ybs.506.1649751173092; Tue, 12 Apr 2022 01:12:53 -0700 (PDT) MIME-Version: 1.0 References: <20220406161856.1669069-1-miquel.raynal@bootlin.com> <20220407004511.3A6D1C385A3@smtp.kernel.org> <20220407101605.7d2a17cc@xps13> <20220412093155.090de9d6@xps13> <20220412094338.382e8754@xps13> <20220412100301.03ccece8@xps13> In-Reply-To: <20220412100301.03ccece8@xps13> From: Geert Uytterhoeven Date: Tue, 12 Apr 2022 10:12:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 0/9] RZN1 DMA support To: Miquel Raynal Cc: Stephen Boyd , Gareth Williams , Magnus Damm , Phil Edworthy , Vinod Koul , Linux-Renesas , dmaengine , Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Thomas Petazzoni , Herve Codina , Clement Leger , Michael Turquette , linux-clk , Viresh Kumar , Andy Shevchenko , Ilpo Jarvinen , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Miquel, On Tue, Apr 12, 2022 at 10:03 AM Miquel Raynal wrote: > geert@linux-m68k.org wrote on Tue, 12 Apr 2022 09:52:25 +0200: > > On Tue, Apr 12, 2022 at 9:43 AM Miquel Raynal wrote: > > > geert@linux-m68k.org wrote on Tue, 12 Apr 2022 09:37:22 +0200: > > > > So far I've been rather terse in giving feedback on these series, > > > > as I'm in wait-and-see mode w.r.t. what else you've planned for the > > > > sysctrl DT node[1] and clock/sys controller code... > > > > > > > > [1] Did I say I'm not that fond of child nodes? But for the dmamux, > > > > it looks like a good solution to handle this. > > > > > > O:-) > > > > > > I plan in the coming days to write a proper reset controller driver > > > that will be queried by the rtc driver (as proposed by Alexandre). > > > > OK. > > > > > Which means I'll have to declare this reset controller as a child of > > > the systrl node. If you disagree with it, you may jump-in, see this > > > thread : > > > > > > Subject: Re: [PATCH 2/7] soc: renesas: rzn1-sysc: Export a > > > function to enable/disable the RTC > > > Date: Wed, 6 Apr 2022 10:32:31 +0200 > > > > But do you need a child node for that? All(most all) other Renesas > > clock drivers provide reset functionality, and none of them use a > > child node for that. > > How do you "request" the reset handle from the consumer driver if it's > not described in the DT? Do you have examples to share? I didn't say it does not need to be described in DT ;-) Just add "#reset-cells = <1>" to the sysctrl node, and nodes can start referring to it using "resets = <&sysctrl N>". Currently, the sysctrl node is already a clock and power-domain provider. Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml shows an R-Car CPG/MSSR node providing clock, power-domain, and reset functionalities. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds