[PATCH v2 0/3] ARM: dts: add ostm support for r7s72100

[PATCH v2 0/3] ARM: dts: add ostm support for r7s72100

[Chris Brandt]

This patch set enables the use of the newly created driver
renesas-ostm.c for the r7s72100 SoC.

v2:
* The biggest change was now the channels are independent of each
  other and have separate nodes in the DT. The first probed will
  be set up as a clock source, and any additional channels probed
  will become a clock event.


Chris Brandt (3):
  ARM: dts: r7s72100: add ostm clock to device tree
  ARM: dts: r7s72100: add ostm to device tree
  ARM: dts: rskrza1: add ostm DT support

 arch/arm/boot/dts/r7s72100-rskrza1.dts     |  8 ++++++++
 arch/arm/boot/dts/r7s72100.dtsi            | 25 +++++++++++++++++++++++++
 include/dt-bindings/clock/r7s72100-clock.h |  4 ++++
 3 files changed, 37 insertions(+)

-- 
2.10.1

[PATCH v2 1/3] ARM: dts: r7s72100: add ostm clock to device tree

[Chris Brandt]

Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r7s72100.dtsi            | 9 +++++++++
 include/dt-bindings/clock/r7s72100-clock.h | 4 ++++
 2 files changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index 3dd427d..d5946df 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -108,6 +108,15 @@
 			clock-output-names = "scif0", "scif1", "scif2", "scif3", "scif4", "scif5", "scif6", "scif7";
 		};
 
+		mstp5_clks: mstp5_clks@fcfe0428 {
+			#clock-cells = <1>;
+			compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks";
+			reg = <0xfcfe0428 4>;
+			clocks = <&p0_clk>, <&p0_clk>;
+			clock-indices = <R7S72100_CLK_OSTM0 R7S72100_CLK_OSTM1>;
+			clock-output-names = "ostm0", "ostm1";
+		};
+
 		mstp7_clks: mstp7_clks@fcfe0430 {
 			#clock-cells = <1>;
 			compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r7s72100-clock.h b/include/dt-bindings/clock/r7s72100-clock.h
index 29e01ed..ce09915 100644
--- a/include/dt-bindings/clock/r7s72100-clock.h
+++ b/include/dt-bindings/clock/r7s72100-clock.h
@@ -25,6 +25,10 @@
 #define R7S72100_CLK_SCIF6	1
 #define R7S72100_CLK_SCIF7	0
 
+/* MSTP5 */
+#define R7S72100_CLK_OSTM0	1
+#define R7S72100_CLK_OSTM1	0
+
 /* MSTP7 */
 #define R7S72100_CLK_ETHER	4
 
-- 
2.10.1

[PATCH v2 2/3] ARM: dts: r7s72100: add ostm to device tree

[Chris Brandt]

Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
v2:
* wrap clock lines to avoid 80 char max
* split into 2 separate channel nodes
---
 arch/arm/boot/dts/r7s72100.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index d5946df..47b2165 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -505,4 +505,20 @@
 		cap-sdio-irq;
 		status = "disabled";
 	};
+
+	ostm0: ostm@fcfec000 {
+		compatible = "renesas,r7s72100-ostm", "renesas,ostm";
+		reg = <0xfcfec000 0x30>;
+		interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
+		clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
+		status = "disabled";
+	};
+
+	ostm1: ostm@fcfec400 {
+		compatible = "renesas,r7s72100-ostm", "renesas,ostm";
+		reg = <0xfcfec400 0x30>;
+		interrupts = <GIC_SPI 103 IRQ_TYPE_EDGE_RISING>;
+		clocks = <&mstp5_clks R7S72100_CLK_OSTM1>;
+		status = "disabled";
+	};
 };
-- 
2.10.1


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/3] ARM: dts: r7s72100: add ostm to device tree

[Sergei Shtylyov]

Hello!

On 1/21/2017 12:20 AM, Chris Brandt wrote:

> Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> ---
> v2:
> * wrap clock lines to avoid 80 char max
> * split into 2 separate channel nodes
> ---
>  arch/arm/boot/dts/r7s72100.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
> index d5946df..47b2165 100644
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -505,4 +505,20 @@
>  		cap-sdio-irq;
>  		status = "disabled";
>  	};
> +
> +	ostm0: ostm@fcfec000 {

    According to devicetree.org, the node name should be generic, i.e. 
"timer@...".

> +		compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> +		reg = <0xfcfec000 0x30>;
> +		interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> +		clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> +		status = "disabled";
> +	};
> +
> +	ostm1: ostm@fcfec400 {

    Likewise.

> +		compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> +		reg = <0xfcfec400 0x30>;
> +		interrupts = <GIC_SPI 103 IRQ_TYPE_EDGE_RISING>;
> +		clocks = <&mstp5_clks R7S72100_CLK_OSTM1>;
> +		status = "disabled";
> +	};
>  };

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 2/3] ARM: dts: r7s72100: add ostm to device tree

[Chris Brandt]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 983 bytes --]

Hello Sergei,

On Saturday, January 21, 2017, Sergei Shtylyov wrote:
> > diff --git a/arch/arm/boot/dts/r7s72100.dtsi
> > b/arch/arm/boot/dts/r7s72100.dtsi index d5946df..47b2165 100644
> > --- a/arch/arm/boot/dts/r7s72100.dtsi
> > +++ b/arch/arm/boot/dts/r7s72100.dtsi
> > @@ -505,4 +505,20 @@
> >  		cap-sdio-irq;
> >  		status = "disabled";
> >  	};
> > +
> > +	ostm0: ostm@fcfec000 {
> 
>     According to devicetree.org, the node name should be generic, i.e.
> "timer@...".
> 
> > +		compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> > +		reg = <0xfcfec000 0x30>;
> > +		interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> > +		clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> > +		status = "disabled";
> > +	};
> > +
> > +	ostm1: ostm@fcfec400 {
> 
>     Likewise.
> 

OK. I will change it.
Thank you!

Chris
N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·zøœzÚÞz)í…æèw*\x1fjg¬±¨\x1e¶‰šŽŠÝ¢j.ïÛ°\½½MŽúgjÌæa×\x02››–' ™©Þ¢¸\f¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾\a«‘êçzZ+ƒùšŽŠÝ¢j"ú!¶i

Re: [PATCH v2 2/3] ARM: dts: r7s72100: add ostm to device tree

[Geert Uytterhoeven]

On Fri, Jan 20, 2017 at 10:20 PM, Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote:
> Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> ---
> v2:
> * wrap clock lines to avoid 80 char max
> * split into 2 separate channel nodes
> ---
>  arch/arm/boot/dts/r7s72100.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
> index d5946df..47b2165 100644
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -505,4 +505,20 @@
>                 cap-sdio-irq;
>                 status = "disabled";
>         };
> +
> +       ostm0: ostm@fcfec000 {
> +               compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> +               reg = <0xfcfec000 0x30>;
> +               interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> +               clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;

Missing power-domains property:

        power-domains = <&cpg_clocks>;

> +               status = "disabled";
> +       };
> +
> +       ostm1: ostm@fcfec400 {
> +               compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> +               reg = <0xfcfec400 0x30>;
> +               interrupts = <GIC_SPI 103 IRQ_TYPE_EDGE_RISING>;
> +               clocks = <&mstp5_clks R7S72100_CLK_OSTM1>;

Likewise.

BTW, they're also missing for the last added device nodes (MMC and SDHI).

> +               status = "disabled";
> +       };
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 2/3] ARM: dts: r7s72100: add ostm to device tree

[Chris Brandt]

Hello Geert,

On Sunday, January 22, 2017, Geert Uytterhoeven wrote:
> > diff --git a/arch/arm/boot/dts/r7s72100.dtsi
> > b/arch/arm/boot/dts/r7s72100.dtsi index d5946df..47b2165 100644
> > --- a/arch/arm/boot/dts/r7s72100.dtsi
> > +++ b/arch/arm/boot/dts/r7s72100.dtsi
> > @@ -505,4 +505,20 @@
> >                 cap-sdio-irq;
> >                 status = "disabled";
> >         };
> > +
> > +       ostm0: ostm@fcfec000 {
> > +               compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> > +               reg = <0xfcfec000 0x30>;
> > +               interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> > +               clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> 
> Missing power-domains property:
> 
>         power-domains = <&cpg_clocks>;
> 
> > +               status = "disabled";
> > +       };
> > +
> > +       ostm1: ostm@fcfec400 {
> > +               compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> > +               reg = <0xfcfec400 0x30>;
> > +               interrupts = <GIC_SPI 103 IRQ_TYPE_EDGE_RISING>;
> > +               clocks = <&mstp5_clks R7S72100_CLK_OSTM1>;
> 
> Likewise.

OK. Thank you.


> BTW, they're also missing for the last added device nodes (MMC and SDHI).

OK, I will submit patches for them as well.

Thank you for the review.

Chris

[PATCH v2 3/3] ARM: dts: rskrza1: add ostm DT support

[Chris Brandt]

Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
v2:
* remove part that was supposed to go in dsti
* now there is a node for each channel
---
 arch/arm/boot/dts/r7s72100-rskrza1.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts
index dd44181..02b59c5 100644
--- a/arch/arm/boot/dts/r7s72100-rskrza1.dts
+++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
@@ -61,6 +61,14 @@
 	status = "okay";
 };
 
+&ostm0 {
+	status = "okay";
+};
+
+&ostm1 {
+	status = "okay";
+};
+
 &scif2 {
 	status = "okay";
 };
-- 
2.10.1


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html