From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 416F2C433FE for ; Fri, 20 May 2022 07:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241614AbiETHNk convert rfc822-to-8bit (ORCPT ); Fri, 20 May 2022 03:13:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234866AbiETHNj (ORCPT ); Fri, 20 May 2022 03:13:39 -0400 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38E73140841; Fri, 20 May 2022 00:13:38 -0700 (PDT) Received: by mail-qk1-f176.google.com with SMTP id x65so2087009qke.2; Fri, 20 May 2022 00:13:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GCrhi2K2Dty2bgxNnj28EIUE9cUht+MAZzziai/dEyk=; b=ZXP1Dbf/xZQBx0+NmsxKiqAq5+cqZZ3RToePL3kTDKdvUGojxgZy4YxLo80C3CcqDv msbYn3C1qhPH7R4msYs8TMyGfPP1xO13nYJ2Qvj313xzZBuRleRp/eaVz2tOR+hhVZz/ Ps63lt3TWn5Z7NP1Atc7e7e/ifVPFFB5ZfXjr9oj9e+KgXJZFBUFyUNgMKEk0QhUHz/c 89Vu7f9kURWbXQ/RTtp7/7E9i7pTn1hKBOjAQ42QEuUmgih5wQ0ZqKd6qyG0KSJxen1L JfjJPejHNnrsMVYMyQZvrLCb7vnVGmKwuks9u8/eCgGnX2rj+g1Vtmsof94TdY4a8W7j nsQw== X-Gm-Message-State: AOAM533ZMtcbDAF1zvP+End5p000CaaQykCBRDOIAYNQIapn4zEcpgme sqlvsxkWsH3Z/KqNvlaXBQrka8s7QVjoUg== X-Google-Smtp-Source: ABdhPJxTQ4fBg9pwRl76dbxTgY0mvGa/fcf3vJH/1xsBLce6fchFkLftXf0Y+YKSTdGQR8qI2RS7FA== X-Received: by 2002:a05:620a:1456:b0:6a3:35dc:2307 with SMTP id i22-20020a05620a145600b006a335dc2307mr3905933qkl.456.1653030817056; Fri, 20 May 2022 00:13:37 -0700 (PDT) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com. [209.85.219.171]) by smtp.gmail.com with ESMTPSA id s65-20020ae9de44000000b006a2f129425asm2412878qkf.130.2022.05.20.00.13.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 00:13:36 -0700 (PDT) Received: by mail-yb1-f171.google.com with SMTP id x2so12448552ybi.8; Fri, 20 May 2022 00:13:35 -0700 (PDT) X-Received: by 2002:a25:e04d:0:b0:64d:6f23:b906 with SMTP id x74-20020a25e04d000000b0064d6f23b906mr8138784ybg.380.1653030815564; Fri, 20 May 2022 00:13:35 -0700 (PDT) MIME-Version: 1.0 References: <20220519153107.696864-1-clement.leger@bootlin.com> <20220519153107.696864-7-clement.leger@bootlin.com> In-Reply-To: <20220519153107.696864-7-clement.leger@bootlin.com> From: Geert Uytterhoeven Date: Fri, 20 May 2022 09:13:23 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v5 06/13] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch To: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , Magnus Damm , Heiner Kallweit , Russell King , Thomas Petazzoni , Herve Codina , =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , netdev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Clément, On Thu, May 19, 2022 at 5:32 PM Clément Léger wrote: > Add bindings for Renesas RZ/N1 Advanced 5 port switch. This switch is > present on Renesas RZ/N1 SoC and was probably provided by MoreThanIP. > This company does not exists anymore and has been bought by Synopsys. > Since this IP can't be find anymore in the Synospsy portfolio, lets use > Renesas as the vendor compatible for this IP. > > Signed-off-by: Clément Léger Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > @@ -0,0 +1,131 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/dsa/renesas,rzn1-a5psw.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/N1 Advanced 5 ports ethernet switch > + > +maintainers: > + - Clément Léger > + > +description: | > + The advanced 5 ports switch is present on the Renesas RZ/N1 SoC family and > + handles 4 ports + 1 CPU management port. > + > +allOf: > + - $ref: dsa.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,r9a06g032-a5psw > + - const: renesas,rzn1-a5psw > + > + reg: > + maxItems: 1 > + > + mdio: > + $ref: /schemas/net/mdio.yaml# > + unevaluatedProperties: false > + > + clocks: > + items: > + - description: AHB clock used for the switch register interface > + - description: Switch system clock > + > + clock-names: > + items: > + - const: hclk > + - const: clk (Good, "clock-names" is present ;-) Missing "power-domains" property. > +examples: > + - | > + #include > + #include > + > + switch@44050000 { > + compatible = "renesas,r9a06g032-a5psw", "renesas,rzn1-a5psw"; > + reg = <0x44050000 0x10000>; > + clocks = <&sysctrl R9A06G032_HCLK_SWITCH>, <&sysctrl R9A06G032_CLK_SWITCH>; > + clock-names = "hclk", "clk"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pins_mdio1>, <&pins_eth3>, <&pins_eth4>; Usually we don't list pinctrl-* properties in examples. The rest LGTM (from an SoC integration PoV), so with the above fixed Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds