From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 3/4] simplefb: Change simplefb_init from module_init to fs_initcall Date: Thu, 13 Nov 2014 09:58:41 +0100 Message-ID: References: <1415830124-28787-1-git-send-email-hdegoede@redhat.com> <1415830124-28787-3-git-send-email-hdegoede@redhat.com> <20141113085238.GE20972@lukather> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20141113085238.GE20972@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: Hans de Goede , Tomi Valkeinen , Stephen Warren , Jean-Christophe Plagniol-Villard , Grant Likely , Rob Herring , Luc Verhaegen , Mike Turquette , David Herrmann , Linux Fbdev development list , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , devicetree , linux-sunxi List-Id: devicetree@vger.kernel.org Hi Maxime, On Thu, Nov 13, 2014 at 9:52 AM, Maxime Ripard wrote: >> -module_init(simplefb_init); >> +/* >> + * While this can be a module, if builtin it's most likely the console >> + * So let's leave module_exit but move module_init to an earlier place >> + */ > > Not really related to this patch itself, but do we want to support > simplefb as a module? It seems like it's going to be most of the time > broken. If it depends on clocks, it won't work as a module, as CCF will have disabled all unused clocks at that point. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds