devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
	Guenter Roeck <linux@roeck-us.net>,
	 Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	 Wim Van Sebroeck <wim@linux-watchdog.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	 linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/5] dt-bindings: watchdog: factor out RZ/N1 watchdog
Date: Wed, 8 Oct 2025 12:19:06 +0200	[thread overview]
Message-ID: <CAMuHMdXdMK30hQrOR8CsK4Y-5ay1T3GUtSFiunnfGNVO4vDwrw@mail.gmail.com> (raw)
In-Reply-To: <20251007152007.14508-9-wsa+renesas@sang-engineering.com>

Hi Wolfram,

On Tue, 7 Oct 2025 at 17:20, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Renesas created different watchdog IPs but they are all handled in the
> same binding documentation. This leads to a lot of conditional handling
> which makes it unnecessarily hard to add new items. Factor out the RZ/N1
> watchdog to make handling easier.
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for your patch!

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/renesas,rzn1-wdt.yaml

RZ/N1 does not support "timeout-sec", right?  As this detail was not
expressed before, you may want to mention that in the patch description.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2025-10-08 10:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07 15:20 [PATCH v3 0/5] dt-bindings: watchdog: factor out RZ watchdogs Wolfram Sang
2025-10-07 15:20 ` [PATCH v3 1/5] dt-bindings: watchdog: factor out RZ/A watchdog Wolfram Sang
2025-10-08 10:04   ` Geert Uytterhoeven
2025-10-07 15:20 ` [PATCH v3 2/5] dt-bindings: watchdog: factor out RZ/N1 watchdog Wolfram Sang
2025-10-08 10:19   ` Geert Uytterhoeven [this message]
2025-10-07 15:20 ` [PATCH v3 3/5] dt-bindings: watchdog: factor out RZ/G2L watchdog Wolfram Sang
2025-10-08 10:25   ` Geert Uytterhoeven
2025-10-07 15:20 ` [PATCH v3 4/5] dt-bindings: watchdog: factor out RZ/V2H(P) watchdog Wolfram Sang
2025-10-08 10:36   ` Geert Uytterhoeven
2025-10-07 15:20 ` [PATCH v3 5/5] dt-bindings: watchdog: renesas,wdt: add SWDT exception for V3H Wolfram Sang
2025-10-08 10:45   ` Geert Uytterhoeven
2025-10-08 13:40     ` Wolfram Sang
2025-10-08 13:17 ` [PATCH v3 0/5] dt-bindings: watchdog: factor out RZ watchdogs Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdXdMK30hQrOR8CsK4Y-5ay1T3GUtSFiunnfGNVO4vDwrw@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=wim@linux-watchdog.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).