Re: [PATCH v4 2/3] media: platform: Add Renesas Input Video Control block driver

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Daniel,

On Mon, 14 Jul 2025 at 17:19, Daniel Scally <dan.scally@ideasonboard.com> wrote:
> Add a driver for the Input Video Control block in an RZ/V2H SoC which
> feeds data into the Arm Mali-C55 ISP.
>
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>

Thanks for your patch!

> --- /dev/null
> +++ b/drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc-dev.c

> +static int rzv2h_ivc_get_hardware_resources(struct rzv2h_ivc *ivc,
> +                                           struct platform_device *pdev)
> +{
> +       const char * const resource_names[RZV2H_IVC_NUM_HW_RESOURCES] = {

static

> +               "reg",
> +               "axi",
> +               "isp",
> +       };

> +static int rzv2h_ivc_probe(struct platform_device *pdev)
> +{
> +       struct device *dev = &pdev->dev;
> +       struct rzv2h_ivc *ivc;
> +       int ret;
> +
> +       ivc = devm_kzalloc(dev, sizeof(*ivc), GFP_KERNEL);
> +       if (!ivc)
> +               return -ENOMEM;
> +
> +       ivc->dev = dev;
> +       platform_set_drvdata(pdev, ivc);
> +       mutex_init(&ivc->lock);
> +       spin_lock_init(&ivc->spinlock);
> +
> +       ret = rzv2h_ivc_get_hardware_resources(ivc, pdev);
> +       if (ret)
> +               return ret;
> +
> +       pm_runtime_set_autosuspend_delay(dev, 2000);
> +       pm_runtime_use_autosuspend(dev);
> +       pm_runtime_enable(dev);
> +
> +       ivc->irqnum = platform_get_irq(pdev, 0);
> +       if (ivc->irqnum < 0) {
> +               dev_err(dev, "failed to get interrupt\n");

No need to print anything, as platform_get_irq() already calls
dev_err_probe() on failure.

> +               return ret;
> +       }
> +
> +       ret = rzv2h_ivc_initialise_subdevice(ivc);
> +       if (ret)
> +               return ret;
> +
> +       return 0;
> +}

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds