From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Claudiu <claudiu.beznea@tuxon.dev>,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
ulf.hansson@linaro.org, linus.walleij@linaro.org,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
magnus.damm@gmail.com, catalin.marinas@arm.com, will@kernel.org,
prabhakar.mahadev-lad.rj@bp.renesas.com,
biju.das.jz@bp.renesas.com, quic_bjorande@quicinc.com,
arnd@arndb.de, konrad.dybcio@linaro.org,
neil.armstrong@linaro.org, nfraprado@collabora.com,
rafal@milecki.pl, wsa+renesas@sang-engineering.com,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH 08/37] clk: renesas: rzg2l: trust value returned by hardware
Date: Thu, 14 Sep 2023 14:18:44 +0200 [thread overview]
Message-ID: <CAMuHMdXjhCth125PHKxrWJENFUhrvXfFJPLhL2ZRY6++azzczA@mail.gmail.com> (raw)
In-Reply-To: <8490f909-c0ad-5a6d-7a97-03c80a8b47ba@omp.ru>
On Tue, Sep 12, 2023 at 6:43 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
> On 9/12/23 7:51 AM, Claudiu wrote:
>
> > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >
> > Initial value of CPG_PL2SDHI_DSEL bits 0..1 or 4..6 is 01b. Hardware user's
> > manual (r01uh0914ej0130-rzg2l-rzg2lc.pdf) specifies that setting 0 is
> > prohibited. The rzg2l_cpg_sd_clk_mux_get_parent() should just read
> > CPG_PL2SDHI_DSEL, trust the value and return the proper clock parent index
> > based on the read value. Do this.
> >
> > Fixes: eaff33646f4cb ("clk: renesas: rzg2l: Add SDHI clk mux support")
> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> > --- a/drivers/clk/renesas/rzg2l-cpg.c
> > +++ b/drivers/clk/renesas/rzg2l-cpg.c
> > @@ -239,14 +239,8 @@ static u8 rzg2l_cpg_sd_clk_mux_get_parent(struct clk_hw *hw)
> >
> > val >>= GET_SHIFT(hwdata->conf);
> > val &= GENMASK(GET_WIDTH(hwdata->conf) - 1, 0);
> > - if (val) {
> > - val--;
> > - } else {
> > - /* Prohibited clk source, change it to 533 MHz(reset value) */
> > - rzg2l_cpg_sd_clk_mux_set_parent(hw, 0);
> > - }
> >
> > - return val;
> > + return val ? --val : val;
>
> return val ? val - 1 : 0;
Definitely, mixing multiple users of the same variable and pre-decrement
is ill-defined.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-09-14 12:19 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 4:51 [PATCH 00/37] Add new Renesas RZ/G3S SoC and RZ/G3S SMARC EVK Claudiu
2023-09-12 4:51 ` [PATCH 01/37] dt-bindings: serial: renesas,scif: document r9a08g045 support Claudiu
2023-09-12 16:00 ` Rob Herring
2023-09-14 9:35 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 02/37] dt-bindings: soc: renesas: document Renesas RZ/G3S SoC variants Claudiu
2023-09-12 16:01 ` Rob Herring
2023-09-14 9:49 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 03/37] dt-bindings: soc: renesas: renesas,rzg2l-sysc: document RZ/G3S SoC Claudiu
2023-09-12 16:01 ` Rob Herring
2023-09-14 9:49 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 04/37] soc: renesas: identify " Claudiu
2023-09-14 9:49 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 05/37] soc: renesas: remove blank lines Claudiu
2023-09-14 9:49 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 06/37] clk: renesas: rzg2l: wait for status bit of SD mux before continuing Claudiu
2023-09-14 11:42 ` Geert Uytterhoeven
2023-09-15 5:35 ` claudiu beznea
2023-09-12 4:51 ` [PATCH 07/37] clk: renesas: rzg2l: lock around writes to mux register Claudiu
2023-09-14 12:13 ` Geert Uytterhoeven
2023-09-15 5:46 ` claudiu beznea
2023-09-12 4:51 ` [PATCH 08/37] clk: renesas: rzg2l: trust value returned by hardware Claudiu
2023-09-12 16:43 ` Sergey Shtylyov
2023-09-14 12:18 ` Geert Uytterhoeven [this message]
2023-09-12 4:51 ` [PATCH 09/37] clk: renesas: rzg2l: fix computation formula Claudiu
2023-09-14 12:55 ` Geert Uytterhoeven
2023-09-26 11:47 ` claudiu beznea
2023-09-26 14:44 ` Geert Uytterhoeven
2023-09-27 8:00 ` Geert Uytterhoeven
2023-09-28 4:55 ` claudiu beznea
2023-09-12 4:51 ` [PATCH 10/37] clk: renesas: rzg2l: use core->name for clock name Claudiu
2023-09-14 13:04 ` Geert Uytterhoeven
2023-09-15 5:47 ` claudiu beznea
2023-09-18 8:03 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 11/37] clk: renesas: rzg2l: simplify a bit the logic in rzg2l_mod_clock_endisable() Claudiu
2023-09-14 13:06 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 12/37] clk: renesas: rzg2l: reduce the critical area Claudiu
2023-09-14 13:12 ` Geert Uytterhoeven
2023-09-15 5:51 ` claudiu beznea
2023-09-15 7:05 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 13/37] clk: renesas: rzg2l: use FIELD_GET() for PLL register fields Claudiu
2023-09-14 13:19 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 14/37] clk: renesas: rzg2l: use u32 for flag and mux_flags Claudiu
2023-09-14 13:29 ` Geert Uytterhoeven
2023-09-18 8:03 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 15/37] clk: renesas: rzg2l: add support for RZ/G3S PLL Claudiu
2023-09-14 13:58 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 16/37] clk: renesas: rzg2l: add struct clk_hw_data Claudiu
2023-09-14 15:17 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 17/37] clk: renesas: rzg2l: remove CPG_SDHI_DSEL from generic header Claudiu
2023-09-14 15:18 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 18/37] clk: renesas: rzg2l: refactor sd mux driver Claudiu
2023-09-14 15:18 ` Geert Uytterhoeven
2023-09-15 7:30 ` claudiu beznea
2023-09-15 8:06 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 19/37] clk: renesas: rzg2l: add a divider clock for RZ/G3S Claudiu
2023-09-12 4:51 ` [PATCH 20/37] dt-bindings: clock: renesas,rzg2l-cpg: document RZ/G3S SoC Claudiu
2023-09-12 16:02 ` Rob Herring
2023-09-15 11:58 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 21/37] dt-bindings: clock: add r9a08g045 CPG clocks and resets definitions Claudiu
2023-09-12 16:03 ` Rob Herring
2023-09-14 15:26 ` Geert Uytterhoeven
2023-09-15 7:24 ` Krzysztof Kozlowski
2023-09-15 7:38 ` Geert Uytterhoeven
2023-09-15 7:42 ` Krzysztof Kozlowski
2023-09-15 11:59 ` Geert Uytterhoeven
2023-09-28 4:54 ` claudiu beznea
2023-09-28 7:25 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 22/37] clk: renesas: add minimal boot support for RZ/G3S SoC Claudiu
2023-09-15 12:52 ` Geert Uytterhoeven
2023-09-18 6:20 ` claudiu beznea
2023-09-18 7:00 ` Geert Uytterhoeven
2023-09-18 7:50 ` claudiu beznea
2023-09-18 9:05 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 23/37] pinctrl: renesas: rzg2l: index all registers based on port offset Claudiu
2023-09-20 13:20 ` Geert Uytterhoeven
2023-09-20 13:43 ` Lad, Prabhakar
2023-09-12 4:51 ` [PATCH 24/37] pinctrl: renesas: rzg2l: adapt for different SD, PWPR register offsets Claudiu
2023-09-21 12:07 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 25/37] pinctrl: renesas: rzg2l: adapt function number for RZ/G3S Claudiu
2023-09-21 12:51 ` Geert Uytterhoeven
2023-09-26 9:55 ` claudiu beznea
2023-09-26 14:23 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 26/37] pinctrl: renesas: rzg2l: move ds and oi to SoC specific configuration Claudiu
2023-09-21 12:54 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 27/37] pinctrl: renesas: rzg2l: add support for different ds values on different groups Claudiu
2023-09-21 13:07 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 28/37] pinctrl: renesas: rzg2l: make struct rzg2l_pinctrl_data::dedicated_pins constant Claudiu
2023-09-21 13:08 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 29/37] dt-bindings: pinctrl: renesas: document RZ/G3S SoC Claudiu
2023-09-12 16:13 ` Rob Herring
2023-09-21 15:00 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 30/37] pinctrl: renesas: rzg2l: add support for " Claudiu
2023-09-21 14:58 ` Geert Uytterhoeven
2023-09-26 10:58 ` claudiu beznea
2023-09-26 14:29 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 31/37] dt-bindings: mmc: renesas,sdhi: Document RZ/G3S support Claudiu
2023-09-12 16:13 ` Rob Herring
2023-09-14 14:47 ` Ulf Hansson
2023-09-14 15:35 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 32/37] arm64: dts: renesas: add initial DTSI for RZ/G3S SoC Claudiu
2023-09-15 13:17 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 33/37] arm64: dts: renesas: rzg3l-smarc-som: add initial support for RZ/G3S SMARC Carrier-II SoM Claudiu
2023-09-15 14:28 ` Geert Uytterhoeven
2023-09-18 6:02 ` claudiu beznea
2023-09-12 4:51 ` [PATCH 34/37] arm64: dts: renesas: rzg3s-smarc: add initial device tree for RZ SMARC Carrier-II board Claudiu
2023-09-15 14:32 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 35/37] dt-bindings: arm: renesas: document SMARC Carrier-II EVK Claudiu
2023-09-12 16:16 ` Rob Herring
2023-09-13 5:32 ` claudiu beznea
2023-09-13 15:16 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 36/37] arm64: dts: renesas: r9a08g045s33-smarc: add initial device tree for RZ/G3S SMARC EVK board Claudiu
2023-09-21 15:02 ` Geert Uytterhoeven
2023-09-12 4:51 ` [PATCH 37/37] arm64: defconfig: enable RZ/G3S (R9A08G045) SoC Claudiu
2023-09-15 14:34 ` Geert Uytterhoeven
2023-09-12 8:55 ` [PATCH 00/37] Add new Renesas RZ/G3S SoC and RZ/G3S SMARC EVK Linus Walleij
2023-09-12 9:03 ` Geert Uytterhoeven
2023-09-12 9:05 ` Linus Walleij
2023-09-13 5:40 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXjhCth125PHKxrWJENFUhrvXfFJPLhL2ZRY6++azzczA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=catalin.marinas@arm.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_bjorande@quicinc.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).