From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: renesas: genmai: enable SDHI0
Date: Fri, 4 Oct 2024 15:23:04 +0200 [thread overview]
Message-ID: <CAMuHMdXjt6raMKqZEms0ZkZcS7O0mgThNVoQnGOrK7_gRoOJkw@mail.gmail.com> (raw)
In-Reply-To: <20240926102005.15475-6-wsa+renesas@sang-engineering.com>
Hi Wolfram,
On Thu, Sep 26, 2024 at 12:20 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> For this to work, User LEDs must be disabled because they share their
> pins with SD data lines.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks for your patch!
> --- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> +++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> @@ -76,7 +76,8 @@ key-1 {
> };
>
> leds {
> - status = "okay";
> + /* Needs SDHI0 to be disabled */
> + status = "disabled";
> compatible = "gpio-leds";
Pity...
>
> led1 {
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.13.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2024-10-04 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 10:20 [PATCH 0/3] ARM: dts: renesas: genmai: enable SDHI and MMCIF Wolfram Sang
2024-09-26 10:20 ` [PATCH 1/3] ARM: dts: renesas: genmai: enable SDHI0 Wolfram Sang
2024-10-04 13:23 ` Geert Uytterhoeven [this message]
2024-10-04 13:40 ` Geert Uytterhoeven
2024-09-26 10:20 ` [PATCH 2/3] ARM: dts: renesas: r7s72100: 'bus-width' is a board property Wolfram Sang
2024-10-04 13:31 ` Geert Uytterhoeven
2024-09-26 10:20 ` [PATCH 3/3] ARM: dts: renesas: genmai: enable MMCIF Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXjt6raMKqZEms0ZkZcS7O0mgThNVoQnGOrK7_gRoOJkw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).