From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A29C433F5 for ; Mon, 25 Apr 2022 16:30:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243432AbiDYQdU (ORCPT ); Mon, 25 Apr 2022 12:33:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243382AbiDYQdR (ORCPT ); Mon, 25 Apr 2022 12:33:17 -0400 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 035FC1D33B; Mon, 25 Apr 2022 09:30:12 -0700 (PDT) Received: by mail-qt1-f177.google.com with SMTP id x21so1230908qtr.12; Mon, 25 Apr 2022 09:30:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HkzV/+2M9zHmKkv5bNxhza8d87qIgaSeR4/CvCviOfQ=; b=2Kk6rDeuTgB4OrDnSqGU3Za1myqVwD/dWhfhnv3Qky8mZkdwIvDQwy9/abzn5TAT77 wLgTHFGVaOosAYmBKywI1xQ4CKfx3jpPYx/wMPbSE1hLJCl/bSK/pvraNtllSWCbdTBq bA73ckq3//sLcUslOBIhS+1GEF6xreoE5Djao/RWj2Rug29jMepyXCqhFu5VqaX0c5/b apd8qDi7HfoglCtxayg7DyRvrEjjkApyQdZEHnGOvMZBsapmv7sPfTOcWv8yuZv48kt0 vEt4q0rHmfoGk/61Xq0YkNd+Gl+Zm7FcibX0ekHNh+wh/HwP9CH6M9xd6O57U+F5c4v0 LgaQ== X-Gm-Message-State: AOAM533o/2gSDGeXjqyfL2b8sZABIYgffHYTHAAww7XEmwYVZxZiuzhT /Ezqbb+bxltfwtIvdpqEIK4SC/9AvgH5ZQ== X-Google-Smtp-Source: ABdhPJx5eEvGk96GMcwbmzSBKCM3cv3JYfyXrnImWf2JSreFhhCPWgoj92dYFLtMxcA+AqLl8Th7wg== X-Received: by 2002:ac8:1191:0:b0:2ed:bb6:ab07 with SMTP id d17-20020ac81191000000b002ed0bb6ab07mr12525257qtj.418.1650904210793; Mon, 25 Apr 2022 09:30:10 -0700 (PDT) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com. [209.85.128.181]) by smtp.gmail.com with ESMTPSA id f39-20020a05622a1a2700b002f367d7a7a5sm2265190qtb.23.2022.04.25.09.30.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 09:30:10 -0700 (PDT) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-2ef5380669cso154297037b3.9; Mon, 25 Apr 2022 09:30:09 -0700 (PDT) X-Received: by 2002:a81:1cd5:0:b0:2f4:c3fc:2174 with SMTP id c204-20020a811cd5000000b002f4c3fc2174mr17984532ywc.512.1650904209650; Mon, 25 Apr 2022 09:30:09 -0700 (PDT) MIME-Version: 1.0 References: <20220421085112.78858-1-miquel.raynal@bootlin.com> <20220421085112.78858-9-miquel.raynal@bootlin.com> In-Reply-To: <20220421085112.78858-9-miquel.raynal@bootlin.com> From: Geert Uytterhoeven Date: Mon, 25 Apr 2022 18:29:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v11 8/9] ARM: dts: r9a06g032: Add the two DMA nodes To: Miquel Raynal Cc: Magnus Damm , Gareth Williams , Phil Edworthy , Vinod Koul , Linux-Renesas , dmaengine , Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Thomas Petazzoni , Herve Codina , Clement Leger , Stephen Boyd , Michael Turquette , linux-clk , Viresh Kumar , Andy Shevchenko , Ilpo Jarvinen , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Miquel, On Thu, Apr 21, 2022 at 10:51 AM Miquel Raynal wrote: > Describe the two DMA controllers available on this SoC. > > Signed-off-by: Miquel Raynal > Reviewed-by: Geert Uytterhoeven Still, a few comments below, valid for both instances... > --- a/arch/arm/boot/dts/r9a06g032.dtsi > +++ b/arch/arm/boot/dts/r9a06g032.dtsi > @@ -200,6 +200,36 @@ nand_controller: nand-controller@40102000 { > status = "disabled"; > }; > > + dma0: dma-controller@40104000 { > + compatible = "renesas,r9a06g032-dma", "renesas,rzn1-dma"; > + reg = <0x40104000 0x1000>; > + interrupts = ; > + clock-names = "hclk"; > + clocks = <&sysctrl R9A06G032_HCLK_DMA0>; > + dma-channels = <8>; > + dma-requests = <16>; > + dma-masters = <1>; > + #dma-cells = <3>; > + block_size = <0xfff>; > + data_width = <3>; This property is deprecated, in favor of "dma-width". > + status = "disabled"; Why not keep it enabled? > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds