From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0D61279792 for ; Tue, 2 Dec 2025 16:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764693687; cv=none; b=sSZtxA140GVIAJJ0hdBowXbJD8v3pkVjEGlXtCnu2ZGyD7mlojyI99PdBn44Zx42L6zFEYXtuhx30EGmbDr+1r6FRTZTqrU7D4UQzFMqIIpyoGw9KqnG6xC/TvWon6h1CvEsPL8ibduEV5HHWxcF/OhDgu1DDX8UB9e5G1dUHwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764693687; c=relaxed/simple; bh=7JWQpNMMWls0pEOEbb/qFxvVCdKg8LNQq2xwgx7Zjik=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=YhfP3gIS2vTRpmVdNLrc88LZNvpNdAkxeJPAM+0OECJahCQ4/CQDeysk7eiaW1U9J+z9RWh3DZNJvXLRc7adPXJts8n7cNm5ung33t/ANf3WtI+9RcG5b6lRPIx7hALUT3i/ClBIrCNpQsfOsIysWGF/WTnvSiE+5l+rFUstDJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-8b2ed01b95dso548569985a.0 for ; Tue, 02 Dec 2025 08:41:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764693685; x=1765298485; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yo/Q77iM2dxCsDJX0wSMsdkdBK/3CM2tnqmsgemQ55M=; b=FLUoYoRMNTip6jV3vPZ0gjyXjDjd+oRjrRbTTe1sejs6w6XAfI+6IUnXMKaiMgkmVc hS9nd0tj1sb1pXIs8bkK4rW6Tabty+z8Q5gI2mSlY0NONgewwA9vZZRU0L6J27xYhUa5 9LfuUuBniDoZqezczJ0AzGE2S50VIwp2d1wagUT3B2tAsOnp40/LXfsIGsRWE4uBItQZ UcHMw92yZD0NRVHIsGNL3NshE1UBIa0XyZrqpArIbhBXPgOtK3Lte+TQNMB3nCHuM65+ SlB+K7bqaqug0kIO8VxyDS+dlYTdKqusPc1e1y5Y+5F7VsQ4hRTFSvAnZTBKPrxmvRp/ 6Z1Q== X-Forwarded-Encrypted: i=1; AJvYcCUSpylXNMplcaBi1TUCYd46CFz51ALquRGweCS11FuIKRrCdwSq/SYWMiQttfEQtGk9GRRwjqxVY2Qk@vger.kernel.org X-Gm-Message-State: AOJu0Yw460TljGUprkf65hk2xFXS0vl+oeTTP1MR3iUJLQ+E2wFAxYwa 7QJo88UG5IZGmH2xz/kosXaC6Ly32Oit7ZMo5QEpAn6iGta7yRZWY92bcSI25kUi X-Gm-Gg: ASbGncu5/bo/UwjxzC6ee8YGQMSFju628z6FB2v1yjfOeZS5fBIUtFFQhyBnRJLESJe SWJVhsTFrixWVJJf+cDOKEhBM3CQ/BoYk/Oex3e5Ee6KO1qxURIMe0oAh7txCZYLkKC5qBHJI84 DkqT8Re/f2/tPUo0zBcBBdA/Nfl9ObGljbpamb3mHgU3YLtr8AK5c712UMFVVpHZFgMsDy/kzG5 L4CdcCTjZ3GQcbFeA0nLmRGSEHbL8wStU47NEMGYEmQWALS6sgmVxokggvsBZDT4IMJ/qCQEwGe ur/yKv5KLD1mrtkQzEg02lAY1qk/hiR0pbWGL+DZs7TTVOvhuJvsHIiix+WwNrVdo1sjr8eBD53 D+iYKpnT9V0RLXgS6U9mFa/s7OPVJ3+DlEcK825Sbpgvh4r5nuCxJ/GIFj2K3u5x67/BKQNQKih rnEVFe/tFK87F4yMWyRXSoZ67CJ3OOeKgiUpnjWtrLqAnML6h7 X-Google-Smtp-Source: AGHT+IGcpvWZMTeC4/LE0/X93PyQFZdMP7NrmbRLypIS1OOAX2IrkaxrVhSp5jUKOl9tp6pnVekKKg== X-Received: by 2002:a05:620a:1a1a:b0:8b2:f31f:ae18 with SMTP id af79cd13be357-8b33d1d11f1mr6114174685a.34.1764693684459; Tue, 02 Dec 2025 08:41:24 -0800 (PST) Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com. [209.85.219.51]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b529c90ccbsm1109576285a.23.2025.12.02.08.41.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Dec 2025 08:41:24 -0800 (PST) Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-88051279e87so56638536d6.3 for ; Tue, 02 Dec 2025 08:41:24 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXOZVd5iY3BojNrja1pzBiRxNArHR/whXB2649QsPRkOKXACItTHblRO1I1AJ+d7YD9SaWKC/jeHGGz@vger.kernel.org X-Received: by 2002:a05:6102:3048:b0:5db:20ea:2329 with SMTP id ada2fe7eead31-5e1de370617mr15734527137.35.1764693347428; Tue, 02 Dec 2025 08:35:47 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251015071420.1173068-1-herve.codina@bootlin.com> <20251015071420.1173068-2-herve.codina@bootlin.com> <5cf2a12a-7c66-4622-b4a9-14896c6df005@gmail.com> <072dde7c-a53c-4525-83ac-57ea38edc0b5@gmail.com> <55076f4b-d523-4f8c-8bd4-0645b790737e@gmail.com> <20251202102619.5cd971cc@bootlin.com> In-Reply-To: <20251202102619.5cd971cc@bootlin.com> From: Geert Uytterhoeven Date: Tue, 2 Dec 2025 17:35:35 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AWmQ_blh_df1oI4YfJoUHGn7ADOVOwmOm5bT6QJUN9usi3sbU4oWN1R6RdMkuuY Message-ID: Subject: Re: [PATCH v4 01/29] Revert "treewide: Fix probing of devices in DT overlays" To: Herve Codina Cc: Kalle Niemi , Rob Herring , Matti Vaittinen , Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Arnd Bergmann , Saravana Kannan , Bjorn Helgaas , Charles Keepax , Richard Fitzgerald , David Rhodes , Linus Walleij , Ulf Hansson , Mark Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Geert Uytterhoeven , Wolfram Sang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Herv=C3=A9, On Tue, 2 Dec 2025 at 10:26, Herve Codina wrote: > On Fri, 28 Nov 2025 10:34:57 +0200 > Kalle Niemi wrote: > > >>>>>> Test system testing drivers for ROHM ICs bisected this commit to= cause > > >>>>>> BD71847 drivers probe to not be called. > > >>>>> This driver (and overlay support) is in linux-next or something o= ut of > > >>>>> tree on top of linux-next? > > >>>>> > > >>>>> Rob > > >>>> Yes the driver is in mainline linux: /drivers/mfd/rohm-bd718x7.c > > >>> I don't see any support to apply overlays in that driver. > > >> Ah. Sorry for the confusion peeps. I asked Kalle to report this with= out > > >> proper consideration. 100% my bad. > > >> > > >> While the bd718x7 drive indeed is mainline (and tested), the actual > > >> 'glue-code' doing the overlay is part of the downstream test > > >> infrastructure. So yes, this is not a bug in upstream kernel - this > > >> falls in the category of an upstream change causing downstream thing= s to > > >> break. So, feel free to say: "Go fix your code" :) > > >> > > >> Now that this is sorted, if someone is still interested in helping u= s to > > >> get our upstream drivers tested - the downstream piece is just takin= g > > >> the compiled device-tree overlay at runtime (via bin-attribute file)= , > > >> and applying it using the of_overlay_fdt_apply(). The approach is > > >> working for our testing purposes when the device is added to I2C/SPI > > >> node which is already enabled. However, in case where we have the I2= C > > >> disabled, and enable it in the same overlay where we add the new dev= ice > > >> - then the new device does not get probed. > > >> > > >> I would be really grateful if someone had a pointer for us. > > > Seems to be fw_devlink related. I suppose if you turn it off it works= ? > > > There's info about the dependencies in sysfs or maybe debugfs. I don'= t > > > remember the details, but that should help to tell you why things > > > aren't probing. > > Rob reverted patches but I plan to continue my work on it. > On my side, I need the reverted patches but I fully understand that, on > your side, you need a working system. > > In order to move forward and find a solution for my next iteration, can y= ou > send your overlay (dtso) used in your working and non working cases? Hmm, I must have missed when Rob applied (part of) this series, as I do an overlay test (using the out-of-tree configfs) on top of every (bi-weekly) renesas-drivers release, and saw no issues during the last few months. So I applied this series and tested loading my SPI EEPROM overlay. And it indeed breaks, with the culprit being this particular patch. Interestingly, quoting from this patch: "While the commit fixed fw_devlink overlay handling for one case, it broke it for another case. So revert it and redo the fix in a separate patch." Where is the separate patch that redid the fix? I assume it is "[PATCH v4 03/29] of: dynamic: Fix overlayed devices not probing because of fw_devlink"? Unfortunately that doesn't fix the issue for me. Quoting more from this patch: "Closes: https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgy= o8x6=3D9F9rZ+-KzjOg@mail.gmail.com/" Strange that it claims to fix the issue reported there, as the failure mode I am seeing is exactly the same as documented in that report? Do you know what is wrong? The overlay I am using is referenced in the bug report linked above. Thanks! Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds