From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] clk: Use of_node_name_eq for node name comparisons Date: Wed, 5 Dec 2018 22:16:45 +0100 Message-ID: References: <20181205195050.4759-5-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20181205195050.4759-5-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Tero Kristo , Ulf Hansson , Linux-Renesas , linux-clk , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" , Linux ARM List-Id: devicetree@vger.kernel.org On Wed, Dec 5, 2018 at 8:50 PM Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For instances using of_node_cmp, this has the side effect of now using > case sensitive comparisons. This should not matter for any FDT based > system which all of these are. > > Cc: Geert Uytterhoeven > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Tero Kristo > Cc: Ulf Hansson > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-clk@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring Reviewed-by: Geert Uytterhoeven > --- > drivers/clk/renesas/clk-mstp.c | 2 +- > drivers/clk/ti/clkctrl.c | 2 +- > drivers/clk/ti/dpll.c | 2 +- > drivers/clk/ux500/u8500_of_clk.c | 10 +++++----- > 4 files changed, 8 insertions(+), 8 deletions(-) For drivers/clk/renesas/clk-mstp.c : Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds