devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: eagle-function-expansion: add eMMC support
@ 2025-09-23 16:15 Wolfram Sang
  2025-10-09 15:18 ` Geert Uytterhoeven
  0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2025-09-23 16:15 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree

Add pinmuxing and configuration of the MMC-capable SDHI instance to make
use of the eMMC.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 .../r8a77970-eagle-function-expansion.dtso      | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle-function-expansion.dtso b/arch/arm64/boot/dts/renesas/r8a77970-eagle-function-expansion.dtso
index 0c005660d8dd..a552a923edea 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970-eagle-function-expansion.dtso
+++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle-function-expansion.dtso
@@ -170,7 +170,24 @@ csi40_in: endpoint {
 	};
 };
 
+&mmc0 {
+	pinctrl-0 = <&mmc_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&d3p3>;
+	vqmmc-supply = <&d1p8>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};
+
 &pfc {
+	mmc_pins: mmc_3_3v {
+		groups = "mmc_data8", "mmc_ctrl";
+		function = "mmc";
+		power-source = <1800>;
+	};
+
 	vin0_pins_parallel: vin0 {
 		groups = "vin0_data12", "vin0_sync", "vin0_clk", "vin0_clkenb";
 		function = "vin0";
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: renesas: eagle-function-expansion: add eMMC support
  2025-09-23 16:15 [PATCH] arm64: dts: renesas: eagle-function-expansion: add eMMC support Wolfram Sang
@ 2025-10-09 15:18 ` Geert Uytterhoeven
  2025-10-09 17:45   ` Wolfram Sang
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2025-10-09 15:18 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-renesas-soc, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, devicetree

On Tue, 23 Sept 2025 at 18:17, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Add pinmuxing and configuration of the MMC-capable SDHI instance to make
> use of the eMMC.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.19.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: renesas: eagle-function-expansion: add eMMC support
  2025-10-09 15:18 ` Geert Uytterhoeven
@ 2025-10-09 17:45   ` Wolfram Sang
  2025-10-10  7:35     ` Geert Uytterhoeven
  0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2025-10-09 17:45 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: linux-renesas-soc, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, devicetree

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

On Thu, Oct 09, 2025 at 05:18:23PM +0200, Geert Uytterhoeven wrote:
> On Tue, 23 Sept 2025 at 18:17, Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > Add pinmuxing and configuration of the MMC-capable SDHI instance to make
> > use of the eMMC.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v6.19.

Thanks. However, I just saw that the node name in pinctrl is bogus,
sorry :( mmc_3_3v is plain wrong, mmc_1_8v would be better, but
actually, I think it should be just mmc0. Voltage switch is not
supported on that board.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: renesas: eagle-function-expansion: add eMMC support
  2025-10-09 17:45   ` Wolfram Sang
@ 2025-10-10  7:35     ` Geert Uytterhoeven
  0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2025-10-10  7:35 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-renesas-soc, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, devicetree

Hi Wolfram,

On Thu, 9 Oct 2025 at 19:45, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> On Thu, Oct 09, 2025 at 05:18:23PM +0200, Geert Uytterhoeven wrote:
> > On Tue, 23 Sept 2025 at 18:17, Wolfram Sang
> > <wsa+renesas@sang-engineering.com> wrote:
> > > Add pinmuxing and configuration of the MMC-capable SDHI instance to make
> > > use of the eMMC.
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > i.e. will queue in renesas-devel for v6.19.
>
> Thanks. However, I just saw that the node name in pinctrl is bogus,
> sorry :( mmc_3_3v is plain wrong, mmc_1_8v would be better, but
> actually, I think it should be just mmc0. Voltage switch is not
> supported on that board.

Thanks, will fix that up to "mmc" (which is what the others are using).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-10-10  7:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-23 16:15 [PATCH] arm64: dts: renesas: eagle-function-expansion: add eMMC support Wolfram Sang
2025-10-09 15:18 ` Geert Uytterhoeven
2025-10-09 17:45   ` Wolfram Sang
2025-10-10  7:35     ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).