From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Cc: Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
Date: Thu, 14 Sep 2017 16:55:50 +0200 [thread overview]
Message-ID: <CAMuHMdXtp0w071eAes0Khpi4jHkkgpZ36vbnReGsNWZ-73qa0g@mail.gmail.com> (raw)
In-Reply-To: <1505398720-4535-1-git-send-email-vladimir.barinov@cogentembedded.com>
Hi Vladimir,
On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
> supported board.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
> Changes in version 2:
> - added own compatible value "shimafuji,kingfisher"
Thanks for the update!
> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> @@ -85,6 +85,8 @@ Boards:
> compatible = "renesas,lager", "renesas,r8a7790"
> - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
> compatible = "renesas,m3ulcb", "renesas,r8a7796";
> + - M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
> + compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796";
> - Marzen (R0P7779A00010S)
> compatible = "renesas,marzen", "renesas,r8a7779"
> - Porter (M2-LCDP)
As Kingfisher is an extension board, I meant to have a separate entry for it,
not tied to M3ULCB or H3ULCB:
- M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
compatible = "shimafuji,kingfisher"
That way you don't need to list it twice (the board part number is the same
for M3ULCB Kingfisher and H3ULCB Kingfisher anyway).
Do you agree?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2017-09-14 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 14:18 [PATCH v2 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings Vladimir Barinov
2017-09-14 14:55 ` Geert Uytterhoeven [this message]
[not found] ` <CAMuHMdXtp0w071eAes0Khpi4jHkkgpZ36vbnReGsNWZ-73qa0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-14 15:00 ` Vladimir Barinov
[not found] ` <0bbc8962-c7f3-3889-1add-9984fa8cea88-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-14 15:19 ` Geert Uytterhoeven
2017-09-15 11:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXtp0w071eAes0Khpi4jHkkgpZ36vbnReGsNWZ-73qa0g@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vladimir.barinov@cogentembedded.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).