From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Biju Das <biju.das@bp.renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 2/2] arm64: dts: renesas: cat875: Remove rxc-skew-ps from ethernet-phy node
Date: Thu, 15 Oct 2020 15:39:36 +0200 [thread overview]
Message-ID: <CAMuHMdXu3AKFAY3b6SfWgpQL9VBJBC9HL4ZK5EFu=7FZ2zJoXA@mail.gmail.com> (raw)
In-Reply-To: <20201015132350.8360-2-biju.das.jz@bp.renesas.com>
Hi Biju,
On Thu, Oct 15, 2020 at 3:24 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> The CAT875 sub board from Silicon Linux uses Realtek phy and the driver
> does not support rxc-skew-ps property.
>
> Fixes: 6b170cd3ed02949f ("arm64: dts: renesas: cat875: Add ethernet support")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/cat875.dtsi
> +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi
> @@ -21,7 +21,6 @@
> status = "okay";
>
> phy0: ethernet-phy@0 {
> - rxc-skew-ps = <1500>;
> reg = <0>;
> interrupt-parent = <&gpio2>;
> interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
Should "rx-internal-delay-ps = <1800>" be added to the avb node instead
(after [1] has entered v5.10-rc1, and the DTS part of [2] has been
applied to renesas-devel)?
[1] [PATCH net-next v4 resend 5/5] ravb: Add support for explicit
internal clock delay configuration
https://lore.kernel.org/linux-renesas-soc/20201001101008.14365-6-geert+renesas@glider.be/
[2] [PATCH v3 0/7] net/ravb: Add support for explicit internal clock
delay configuration
https://lore.kernel.org/linux-renesas-soc/20200819134344.27813-1-geert+renesas@glider.be
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-10-15 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 13:23 [PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop rxc-skew-ps from ethernet-phy node Biju Das
2020-10-15 13:23 ` [PATCH 2/2] arm64: dts: renesas: cat875: Remove " Biju Das
2020-10-15 13:39 ` Geert Uytterhoeven [this message]
2020-10-16 6:13 ` Biju Das
2020-10-16 6:31 ` Geert Uytterhoeven
2020-10-15 13:41 ` [PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop " Geert Uytterhoeven
2020-10-16 6:15 ` Biju Das
2020-10-16 6:30 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXu3AKFAY3b6SfWgpQL9VBJBC9HL4ZK5EFu=7FZ2zJoXA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).