From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver Date: Tue, 6 Dec 2011 12:00:12 +0100 Message-ID: References: <20111202192618.GC3037@localhost.localdomain> <1322867573.11728.22.camel@pasglop> <20111205161157.GA27550@localhost.localdomain> <20111205180253.GB29812@localhost.localdomain> <20111205192605.GD29812@localhost.localdomain> <20111206093709.GB2274@linaro.org> <20111206104654.GN14542@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20111206104654.GN14542@n2100.arm.linux.org.uk> Sender: linux-next-owner@vger.kernel.org To: Russell King - ARM Linux Cc: Dave Martin , Nicolas Pitre , Benjamin Herrenschmidt , Linus Torvalds , Anton Vorontsov , Alan Cox , Stephen Rothwell , Andrew Morton , devicetree-discuss@lists.ozlabs.org, LKML , linux-ide@vger.kernel.org, Randy Dunlap , linux-next@vger.kernel.org, Ingo Molnar , Jeff Garzik , Pawel Moll , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Tue, Dec 6, 2011 at 11:46, Russell King - ARM Linux wrote: > But.. let's make one thing clear: Alan Cox and Linus have been going = on > about how IRQ0 should not be used. =C2=A0Let's be crystal clear: even= x86 > uses IRQ0. =C2=A0It happens to be the PIC timer, and that gets claime= d early > on during the x86 boot. =C2=A0So please don't tell me that x86 avoids= IRQ0. > It doesn't. =C2=A0It just happens that x86 never shows IRQ0 to anythi= ng but > the i8253 PIC driver. It's shown in /proc/interrupts due to a "bug" in show_interrupts(). The (gmail damaged) patch below fixes this bug. =46rom 46f51a2d42548358868a34df00c2a4e47bbdf691 Mon Sep 17 00:00:00 200= 1 =46rom: Geert Uytterhoeven Date: Tue, 6 Dec 2011 11:55:05 +0100 Subject: [PATCH] /proc/interrupts: irq zero is invalid As zero is an invalid irq number, show_interrupts() should not try to print it. Just return after printing the header for i =3D=3D 0. Signed-off-by: Geert Uytterhoeven --- kernel/irq/proc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index 4bd4faa..5b8bbf0 100644 --- a/kernel/irq/proc.c +++ b/kernel/irq/proc.c @@ -439,6 +439,7 @@ int show_interrupts(struct seq_file *p, void *v) for_each_online_cpu(j) seq_printf(p, "CPU%-8d", j); seq_putc(p, '\n'); + return 0; } desc =3D irq_to_desc(i); --=20 1.7.0.4 Gr{oetje,eeting}s, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-= m68k.org In personal conversations with technical people, I call myself a hacker= =2E But when I'm talking to journalists I just say "programmer" or something li= ke that. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds