* [PATCH 1/5] arm64: dts: renesas: rzg2l-smarc-som: Drop enabling WDT2
2022-10-09 23:00 [PATCH 0/5] arm64: dts: renesas: rzg2l/rzg2lc/rzg2ul/rzv2l: Drop WDT2 Prabhakar
@ 2022-10-09 23:00 ` Prabhakar
2022-10-10 6:53 ` Wolfram Sang
2022-10-09 23:00 ` [PATCH 2/5] arm64: dts: renesas: rzg2lc-smarc-som: " Prabhakar
` (3 subsequent siblings)
4 siblings, 1 reply; 19+ messages in thread
From: Prabhakar @ 2022-10-09 23:00 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski
Cc: linux-renesas-soc, devicetree, linux-kernel, Prabhakar, Biju Das,
Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
used from CA55 CPU would result in an unexpected behaviour. Hence drop
enabling WDT2.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi b/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
index c4faff092380..fbbb4f03440b 100644
--- a/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
@@ -351,8 +351,3 @@ &wdt1 {
status = "okay";
timeout-sec = <60>;
};
-
-&wdt2 {
- status = "okay";
- timeout-sec = <60>;
-};
--
2.25.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 1/5] arm64: dts: renesas: rzg2l-smarc-som: Drop enabling WDT2
2022-10-09 23:00 ` [PATCH 1/5] arm64: dts: renesas: rzg2l-smarc-som: Drop enabling WDT2 Prabhakar
@ 2022-10-10 6:53 ` Wolfram Sang
2022-10-10 20:00 ` Lad, Prabhakar
0 siblings, 1 reply; 19+ messages in thread
From: Wolfram Sang @ 2022-10-10 6:53 UTC (permalink / raw)
To: Prabhakar
Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
linux-renesas-soc, devicetree, linux-kernel, Biju Das,
Lad Prabhakar
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Mon, Oct 10, 2022 at 12:00:40AM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> used from CA55 CPU would result in an unexpected behaviour. Hence drop
> enabling WDT2.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
I'd squash patches 1+2, but that's minor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/5] arm64: dts: renesas: rzg2l-smarc-som: Drop enabling WDT2
2022-10-10 6:53 ` Wolfram Sang
@ 2022-10-10 20:00 ` Lad, Prabhakar
2022-10-11 7:39 ` Geert Uytterhoeven
0 siblings, 1 reply; 19+ messages in thread
From: Lad, Prabhakar @ 2022-10-10 20:00 UTC (permalink / raw)
To: Wolfram Sang, Prabhakar, Geert Uytterhoeven, Magnus Damm,
Rob Herring, Krzysztof Kozlowski, linux-renesas-soc, devicetree,
linux-kernel, Biju Das, Lad Prabhakar
Hi Wolfram,
Thank you for the review.
On Mon, Oct 10, 2022 at 7:53 AM Wolfram Sang <wsa@kernel.org> wrote:
>
> On Mon, Oct 10, 2022 at 12:00:40AM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> > used from CA55 CPU would result in an unexpected behaviour. Hence drop
> > enabling WDT2.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> I'd squash patches 1+2, but that's minor.
>
OK, I'll wait for Geert before sending a v2.
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/5] arm64: dts: renesas: rzg2l-smarc-som: Drop enabling WDT2
2022-10-10 20:00 ` Lad, Prabhakar
@ 2022-10-11 7:39 ` Geert Uytterhoeven
2022-10-11 7:51 ` Lad, Prabhakar
0 siblings, 1 reply; 19+ messages in thread
From: Geert Uytterhoeven @ 2022-10-11 7:39 UTC (permalink / raw)
To: Lad, Prabhakar
Cc: Wolfram Sang, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
linux-renesas-soc, devicetree, linux-kernel, Biju Das,
Lad Prabhakar
Hi Prabhakar,
On Mon, Oct 10, 2022 at 10:01 PM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Mon, Oct 10, 2022 at 7:53 AM Wolfram Sang <wsa@kernel.org> wrote:
> > On Mon, Oct 10, 2022 at 12:00:40AM +0100, Prabhakar wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> > > used from CA55 CPU would result in an unexpected behaviour. Hence drop
> > > enabling WDT2.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > I'd squash patches 1+2, but that's minor.
> >
> OK, I'll wait for Geert before sending a v2.
I'd even squash the whole series into a single patch
"arm64: dts: renesas: rzg2l: Drop WDT2 node".
If that would be the only change for v2, I can take care of that while
applying.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 1/5] arm64: dts: renesas: rzg2l-smarc-som: Drop enabling WDT2
2022-10-11 7:39 ` Geert Uytterhoeven
@ 2022-10-11 7:51 ` Lad, Prabhakar
2022-10-11 8:13 ` Geert Uytterhoeven
0 siblings, 1 reply; 19+ messages in thread
From: Lad, Prabhakar @ 2022-10-11 7:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Wolfram Sang, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
linux-renesas-soc, devicetree, linux-kernel, Biju Das,
Lad Prabhakar
Hi Geert,
On Tue, Oct 11, 2022 at 8:39 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Mon, Oct 10, 2022 at 10:01 PM Lad, Prabhakar
> <prabhakar.csengg@gmail.com> wrote:
> > On Mon, Oct 10, 2022 at 7:53 AM Wolfram Sang <wsa@kernel.org> wrote:
> > > On Mon, Oct 10, 2022 at 12:00:40AM +0100, Prabhakar wrote:
> > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > >
> > > > WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> > > > used from CA55 CPU would result in an unexpected behaviour. Hence drop
> > > > enabling WDT2.
> > > >
> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > >
> > > I'd squash patches 1+2, but that's minor.
> > >
> > OK, I'll wait for Geert before sending a v2.
>
> I'd even squash the whole series into a single patch
> "arm64: dts: renesas: rzg2l: Drop WDT2 node".
>
OK.
> If that would be the only change for v2, I can take care of that while
> applying.
>
Thanks for taking care of it.
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/5] arm64: dts: renesas: rzg2l-smarc-som: Drop enabling WDT2
2022-10-11 7:51 ` Lad, Prabhakar
@ 2022-10-11 8:13 ` Geert Uytterhoeven
0 siblings, 0 replies; 19+ messages in thread
From: Geert Uytterhoeven @ 2022-10-11 8:13 UTC (permalink / raw)
To: Lad, Prabhakar
Cc: Wolfram Sang, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
linux-renesas-soc, devicetree, linux-kernel, Biju Das,
Lad Prabhakar
On Tue, Oct 11, 2022 at 9:51 AM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Tue, Oct 11, 2022 at 8:39 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Mon, Oct 10, 2022 at 10:01 PM Lad, Prabhakar
> > <prabhakar.csengg@gmail.com> wrote:
> > > On Mon, Oct 10, 2022 at 7:53 AM Wolfram Sang <wsa@kernel.org> wrote:
> > > > On Mon, Oct 10, 2022 at 12:00:40AM +0100, Prabhakar wrote:
> > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > >
> > > > > WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> > > > > used from CA55 CPU would result in an unexpected behaviour. Hence drop
> > > > > enabling WDT2.
> > > > >
> > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > >
> > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > >
> > > > I'd squash patches 1+2, but that's minor.
> > > >
> > > OK, I'll wait for Geert before sending a v2.
> >
> > I'd even squash the whole series into a single patch
> > "arm64: dts: renesas: rzg2l: Drop WDT2 node".
> >
> OK.
>
> > If that would be the only change for v2, I can take care of that while
> > applying.
> >
> Thanks for taking care of it.
OK.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 2/5] arm64: dts: renesas: rzg2lc-smarc-som: Drop enabling WDT2
2022-10-09 23:00 [PATCH 0/5] arm64: dts: renesas: rzg2l/rzg2lc/rzg2ul/rzv2l: Drop WDT2 Prabhakar
2022-10-09 23:00 ` [PATCH 1/5] arm64: dts: renesas: rzg2l-smarc-som: Drop enabling WDT2 Prabhakar
@ 2022-10-09 23:00 ` Prabhakar
2022-10-10 6:53 ` Wolfram Sang
2022-10-11 8:13 ` Geert Uytterhoeven
2022-10-09 23:00 ` [PATCH 3/5] arm64: dts: renesas: r9a07g044: Drop WDT2 node Prabhakar
` (2 subsequent siblings)
4 siblings, 2 replies; 19+ messages in thread
From: Prabhakar @ 2022-10-09 23:00 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski
Cc: linux-renesas-soc, devicetree, linux-kernel, Prabhakar, Biju Das,
Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
used from CA55 CPU would result in an unexpected behaviour. Hence drop
enabling WDT2.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/rzg2lc-smarc-som.dtsi | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/rzg2lc-smarc-som.dtsi b/arch/arm64/boot/dts/renesas/rzg2lc-smarc-som.dtsi
index 78e6e2376b01..8a0d56872de7 100644
--- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc-som.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc-som.dtsi
@@ -276,8 +276,3 @@ &wdt1 {
status = "okay";
timeout-sec = <60>;
};
-
-&wdt2 {
- status = "okay";
- timeout-sec = <60>;
-};
--
2.25.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 2/5] arm64: dts: renesas: rzg2lc-smarc-som: Drop enabling WDT2
2022-10-09 23:00 ` [PATCH 2/5] arm64: dts: renesas: rzg2lc-smarc-som: " Prabhakar
@ 2022-10-10 6:53 ` Wolfram Sang
2022-10-11 8:13 ` Geert Uytterhoeven
1 sibling, 0 replies; 19+ messages in thread
From: Wolfram Sang @ 2022-10-10 6:53 UTC (permalink / raw)
To: Prabhakar
Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
linux-renesas-soc, devicetree, linux-kernel, Biju Das,
Lad Prabhakar
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On Mon, Oct 10, 2022 at 12:00:41AM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> used from CA55 CPU would result in an unexpected behaviour. Hence drop
> enabling WDT2.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/5] arm64: dts: renesas: rzg2lc-smarc-som: Drop enabling WDT2
2022-10-09 23:00 ` [PATCH 2/5] arm64: dts: renesas: rzg2lc-smarc-som: " Prabhakar
2022-10-10 6:53 ` Wolfram Sang
@ 2022-10-11 8:13 ` Geert Uytterhoeven
1 sibling, 0 replies; 19+ messages in thread
From: Geert Uytterhoeven @ 2022-10-11 8:13 UTC (permalink / raw)
To: Prabhakar
Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, linux-renesas-soc,
devicetree, linux-kernel, Biju Das, Lad Prabhakar
On Mon, Oct 10, 2022 at 1:01 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> used from CA55 CPU would result in an unexpected behaviour. Hence drop
> enabling WDT2.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/5] arm64: dts: renesas: r9a07g044: Drop WDT2 node
2022-10-09 23:00 [PATCH 0/5] arm64: dts: renesas: rzg2l/rzg2lc/rzg2ul/rzv2l: Drop WDT2 Prabhakar
2022-10-09 23:00 ` [PATCH 1/5] arm64: dts: renesas: rzg2l-smarc-som: Drop enabling WDT2 Prabhakar
2022-10-09 23:00 ` [PATCH 2/5] arm64: dts: renesas: rzg2lc-smarc-som: " Prabhakar
@ 2022-10-09 23:00 ` Prabhakar
2022-10-10 6:54 ` Wolfram Sang
2022-10-11 8:14 ` Geert Uytterhoeven
2022-10-09 23:00 ` [PATCH 4/5] arm64: dts: renesas: r9a07g054: " Prabhakar
2022-10-09 23:00 ` [PATCH 5/5] arm64: dts: renesas: r9a07g043: " Prabhakar
4 siblings, 2 replies; 19+ messages in thread
From: Prabhakar @ 2022-10-09 23:00 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski
Cc: linux-renesas-soc, devicetree, linux-kernel, Prabhakar, Biju Das,
Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
used from CA55 CPU would result in an unexpected behaviour. Hence drop
WDT2 node from RZ/G2L SoC DTSI.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
index 2283d4fb8736..c606d9ef5991 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
@@ -994,21 +994,6 @@ wdt1: watchdog@12800c00 {
status = "disabled";
};
- wdt2: watchdog@12800400 {
- compatible = "renesas,r9a07g044-wdt",
- "renesas,rzg2l-wdt";
- reg = <0 0x12800400 0 0x400>;
- clocks = <&cpg CPG_MOD R9A07G044_WDT2_PCLK>,
- <&cpg CPG_MOD R9A07G044_WDT2_CLK>;
- clock-names = "pclk", "oscclk";
- interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "wdt", "perrout";
- resets = <&cpg R9A07G044_WDT2_PRESETN>;
- power-domains = <&cpg>;
- status = "disabled";
- };
-
ostm0: timer@12801000 {
compatible = "renesas,r9a07g044-ostm",
"renesas,ostm";
--
2.25.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 3/5] arm64: dts: renesas: r9a07g044: Drop WDT2 node
2022-10-09 23:00 ` [PATCH 3/5] arm64: dts: renesas: r9a07g044: Drop WDT2 node Prabhakar
@ 2022-10-10 6:54 ` Wolfram Sang
2022-10-11 8:14 ` Geert Uytterhoeven
1 sibling, 0 replies; 19+ messages in thread
From: Wolfram Sang @ 2022-10-10 6:54 UTC (permalink / raw)
To: Prabhakar
Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
linux-renesas-soc, devicetree, linux-kernel, Biju Das,
Lad Prabhakar
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
On Mon, Oct 10, 2022 at 12:00:42AM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> used from CA55 CPU would result in an unexpected behaviour. Hence drop
> WDT2 node from RZ/G2L SoC DTSI.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Again, I'd squash patches 3-5.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/5] arm64: dts: renesas: r9a07g044: Drop WDT2 node
2022-10-09 23:00 ` [PATCH 3/5] arm64: dts: renesas: r9a07g044: Drop WDT2 node Prabhakar
2022-10-10 6:54 ` Wolfram Sang
@ 2022-10-11 8:14 ` Geert Uytterhoeven
1 sibling, 0 replies; 19+ messages in thread
From: Geert Uytterhoeven @ 2022-10-11 8:14 UTC (permalink / raw)
To: Prabhakar
Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, linux-renesas-soc,
devicetree, linux-kernel, Biju Das, Lad Prabhakar
On Mon, Oct 10, 2022 at 1:01 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> used from CA55 CPU would result in an unexpected behaviour. Hence drop
> WDT2 node from RZ/G2L SoC DTSI.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 4/5] arm64: dts: renesas: r9a07g054: Drop WDT2 node
2022-10-09 23:00 [PATCH 0/5] arm64: dts: renesas: rzg2l/rzg2lc/rzg2ul/rzv2l: Drop WDT2 Prabhakar
` (2 preceding siblings ...)
2022-10-09 23:00 ` [PATCH 3/5] arm64: dts: renesas: r9a07g044: Drop WDT2 node Prabhakar
@ 2022-10-09 23:00 ` Prabhakar
2022-10-10 6:54 ` Wolfram Sang
2022-10-11 8:19 ` Geert Uytterhoeven
2022-10-09 23:00 ` [PATCH 5/5] arm64: dts: renesas: r9a07g043: " Prabhakar
4 siblings, 2 replies; 19+ messages in thread
From: Prabhakar @ 2022-10-09 23:00 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski
Cc: linux-renesas-soc, devicetree, linux-kernel, Prabhakar, Biju Das,
Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
used from CA55 CPU would result in an unexpected behaviour. Hence drop
WDT2 node from RZ/V2L SoC DTSI.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
index 358d4c34465f..7c7bbe377699 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
@@ -1000,21 +1000,6 @@ wdt1: watchdog@12800c00 {
status = "disabled";
};
- wdt2: watchdog@12800400 {
- compatible = "renesas,r9a07g054-wdt",
- "renesas,rzg2l-wdt";
- reg = <0 0x12800400 0 0x400>;
- clocks = <&cpg CPG_MOD R9A07G054_WDT2_PCLK>,
- <&cpg CPG_MOD R9A07G054_WDT2_CLK>;
- clock-names = "pclk", "oscclk";
- interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "wdt", "perrout";
- resets = <&cpg R9A07G054_WDT2_PRESETN>;
- power-domains = <&cpg>;
- status = "disabled";
- };
-
ostm0: timer@12801000 {
compatible = "renesas,r9a07g054-ostm",
"renesas,ostm";
--
2.25.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 4/5] arm64: dts: renesas: r9a07g054: Drop WDT2 node
2022-10-09 23:00 ` [PATCH 4/5] arm64: dts: renesas: r9a07g054: " Prabhakar
@ 2022-10-10 6:54 ` Wolfram Sang
2022-10-11 8:19 ` Geert Uytterhoeven
1 sibling, 0 replies; 19+ messages in thread
From: Wolfram Sang @ 2022-10-10 6:54 UTC (permalink / raw)
To: Prabhakar
Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
linux-renesas-soc, devicetree, linux-kernel, Biju Das,
Lad Prabhakar
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
On Mon, Oct 10, 2022 at 12:00:43AM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> used from CA55 CPU would result in an unexpected behaviour. Hence drop
> WDT2 node from RZ/V2L SoC DTSI.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 4/5] arm64: dts: renesas: r9a07g054: Drop WDT2 node
2022-10-09 23:00 ` [PATCH 4/5] arm64: dts: renesas: r9a07g054: " Prabhakar
2022-10-10 6:54 ` Wolfram Sang
@ 2022-10-11 8:19 ` Geert Uytterhoeven
1 sibling, 0 replies; 19+ messages in thread
From: Geert Uytterhoeven @ 2022-10-11 8:19 UTC (permalink / raw)
To: Prabhakar
Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, linux-renesas-soc,
devicetree, linux-kernel, Biju Das, Lad Prabhakar
Hi Prabhakar,
On Mon, Oct 10, 2022 at 1:01 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> used from CA55 CPU would result in an unexpected behaviour. Hence drop
> WDT2 node from RZ/V2L SoC DTSI.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
> @@ -1000,21 +1000,6 @@ wdt1: watchdog@12800c00 {
> status = "disabled";
> };
>
> - wdt2: watchdog@12800400 {
> - compatible = "renesas,r9a07g054-wdt",
> - "renesas,rzg2l-wdt";
> - reg = <0 0x12800400 0 0x400>;
> - clocks = <&cpg CPG_MOD R9A07G054_WDT2_PCLK>,
> - <&cpg CPG_MOD R9A07G054_WDT2_CLK>;
> - clock-names = "pclk", "oscclk";
> - interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "wdt", "perrout";
> - resets = <&cpg R9A07G054_WDT2_PRESETN>;
> - power-domains = <&cpg>;
> - status = "disabled";
> - };
> -
> ostm0: timer@12801000 {
> compatible = "renesas,r9a07g054-ostm",
> "renesas,ostm";
As this is hardware description, and the node is disabled by default,
we could keep it. However, as it is to be used by the CM33, its
interrupts property should point to the CM33 NVIC instead of the
CA55 GIC. So let's drop it for now...
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 5/5] arm64: dts: renesas: r9a07g043: Drop WDT2 node
2022-10-09 23:00 [PATCH 0/5] arm64: dts: renesas: rzg2l/rzg2lc/rzg2ul/rzv2l: Drop WDT2 Prabhakar
` (3 preceding siblings ...)
2022-10-09 23:00 ` [PATCH 4/5] arm64: dts: renesas: r9a07g054: " Prabhakar
@ 2022-10-09 23:00 ` Prabhakar
2022-10-10 6:54 ` Wolfram Sang
2022-10-11 8:19 ` Geert Uytterhoeven
4 siblings, 2 replies; 19+ messages in thread
From: Prabhakar @ 2022-10-09 23:00 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski
Cc: linux-renesas-soc, devicetree, linux-kernel, Prabhakar, Biju Das,
Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
used from CA55 CPU would result in an unexpected behaviour. Hence drop
WDT2 node from RZ/G2UL SoC DTSI.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
index 689aa4ba416b..c1fb29de2fa4 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
@@ -820,21 +820,6 @@ wdt0: watchdog@12800800 {
status = "disabled";
};
- wdt2: watchdog@12800400 {
- compatible = "renesas,r9a07g043-wdt",
- "renesas,rzg2l-wdt";
- reg = <0 0x12800400 0 0x400>;
- clocks = <&cpg CPG_MOD R9A07G043_WDT2_PCLK>,
- <&cpg CPG_MOD R9A07G043_WDT2_CLK>;
- clock-names = "pclk", "oscclk";
- interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "wdt", "perrout";
- resets = <&cpg R9A07G043_WDT2_PRESETN>;
- power-domains = <&cpg>;
- status = "disabled";
- };
-
ostm0: timer@12801000 {
compatible = "renesas,r9a07g043-ostm",
"renesas,ostm";
--
2.25.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 5/5] arm64: dts: renesas: r9a07g043: Drop WDT2 node
2022-10-09 23:00 ` [PATCH 5/5] arm64: dts: renesas: r9a07g043: " Prabhakar
@ 2022-10-10 6:54 ` Wolfram Sang
2022-10-11 8:19 ` Geert Uytterhoeven
1 sibling, 0 replies; 19+ messages in thread
From: Wolfram Sang @ 2022-10-10 6:54 UTC (permalink / raw)
To: Prabhakar
Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
linux-renesas-soc, devicetree, linux-kernel, Biju Das,
Lad Prabhakar
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
On Mon, Oct 10, 2022 at 12:00:44AM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> used from CA55 CPU would result in an unexpected behaviour. Hence drop
> WDT2 node from RZ/G2UL SoC DTSI.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 5/5] arm64: dts: renesas: r9a07g043: Drop WDT2 node
2022-10-09 23:00 ` [PATCH 5/5] arm64: dts: renesas: r9a07g043: " Prabhakar
2022-10-10 6:54 ` Wolfram Sang
@ 2022-10-11 8:19 ` Geert Uytterhoeven
1 sibling, 0 replies; 19+ messages in thread
From: Geert Uytterhoeven @ 2022-10-11 8:19 UTC (permalink / raw)
To: Prabhakar
Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, linux-renesas-soc,
devicetree, linux-kernel, Biju Das, Lad Prabhakar
On Mon, Oct 10, 2022 at 1:01 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if
> used from CA55 CPU would result in an unexpected behaviour. Hence drop
> WDT2 node from RZ/G2UL SoC DTSI.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 19+ messages in thread