From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haojian Zhuang Subject: Re: [PATCH v2 5/7] ARM: mmp: append OF support on pxa168 Date: Mon, 9 Apr 2012 09:47:38 +0800 Message-ID: References: <1330950111-30797-1-git-send-email-haojian.zhuang@marvell.com> <1330950111-30797-6-git-send-email-haojian.zhuang@marvell.com> <87ty0tznlb.fsf@laptop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <87ty0tznlb.fsf-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Chris Ball Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Haojian Zhuang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Apr 9, 2012 at 9:43 AM, Chris Ball wrote: > Hi, > > On Mon, Mar 05 2012, Haojian Zhuang wrote: >> +static int __init mmp_intc_add_irq_domain(struct device_node *np, >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0struct device_node *parent) >> +{ >> + =A0 =A0 irq_domain_add_simple(np, 0); >> + =A0 =A0 return 0; >> +} >> + >> +static int __init mmp_gpio_add_irq_domain(struct device_node *np, >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0struct device_node *parent) >> +{ >> + =A0 =A0 irq_domain_add_simple(np, IRQ_GPIO_START); >> + =A0 =A0 return 0; >> +} > > This patch was merged for 3.4-rc1, but it fails to compile because Grant > removed irq_domain_add_simple() in 3.4-rc1. > Noticed. I'll fix it. Best Regards Haojian