From: Haojian Zhuang <haojian.zhuang@gmail.com>
To: Qing Xu <qingx@marvell.com>
Cc: Linux Russell <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
cxie4@marvell.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 7/7] mfd: max8925: add dts
Date: Fri, 23 Nov 2012 16:45:08 +0800 [thread overview]
Message-ID: <CAN1soZy+JCfsroyUBFe9M_MW-sakcWwuqQMT5h0=+Haq+SJ5fw@mail.gmail.com> (raw)
In-Reply-To: <1352188180-10028-1-git-send-email-qingx@marvell.com>
On Tue, Nov 6, 2012 at 3:49 PM, Qing Xu <qingx@marvell.com> wrote:
> From: Qing Xu <qingx@marvell.com>
>
> add max8925 dts support into mmp2 brownstone platform
>
> Signed-off-by: Qing Xu <qingx@marvell.com>
> ---
> arch/arm/boot/dts/mmp2-brownstone.dts | 166 +++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/mmp2.dtsi | 4 +-
> 2 files changed, 169 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mmp2-brownstone.dts b/arch/arm/boot/dts/mmp2-brownstone.dts
> index c9b4f27..e22f58c 100644
> --- a/arch/arm/boot/dts/mmp2-brownstone.dts
> +++ b/arch/arm/boot/dts/mmp2-brownstone.dts
> @@ -29,6 +29,172 @@
> };
> twsi1: i2c@d4011000 {
> status = "okay";
> + pmic: max8925@3c {
> + compatible = "marvell,max8925";
> + reg = <0x3c>;
> + interrupts = <1 0>;
> + interrupt-parent = <&intcmux4>;
> + interrupt-controller;
> + #interrupt-cells = <1>;
> +
> + regulators {
> + SDV1 {
> + regulator-min-microvolt = <637500>;
> + regulator-max-microvolt = <1425000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> + SDV2 {
> + regulator-min-microvolt = <650000>;
> + regulator-max-microvolt = <2225000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> + };
> + backlight {
> + dual-string = <0>;
> + };
> + charger {
> + batt-detect = <0>;
> + topoff-threshold = <1>;
> + fast-charge = <7>;
> + no-temp-support = <0>;
> + no-insert-detect = <0>;
> + };
> + rtc {
> +
> + };
> + onkey {
> +
> + };
> + touch {
> +
> + };
Please remove these empty entries. Those mfd client drivers didn't parse any
property from DTS file.
> + };
> };
> rtc: rtc@d4010000 {
> status = "okay";
> diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
> index 80f74e2..2165a17 100644
> --- a/arch/arm/boot/dts/mmp2.dtsi
> +++ b/arch/arm/boot/dts/mmp2.dtsi
> @@ -41,7 +41,7 @@
> mrvl,intc-nr-irqs = <64>;
> };
>
> - intcmux4@d4282150 {
> + intcmux4: intcmux4@d4282150 {
> compatible = "mrvl,mmp2-mux-intc";
> interrupts = <4>;
> interrupt-controller;
> @@ -196,6 +196,8 @@
> compatible = "mrvl,mmp-twsi";
> reg = <0xd4011000 0x1000>;
> interrupts = <7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> mrvl,i2c-fast-mode;
> status = "disabled";
> };
> --
> 1.7.0.4
>
prev parent reply other threads:[~2012-11-23 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 7:49 [PATCH 7/7] mfd: max8925: add dts Qing Xu
2012-11-23 7:29 ` Qing Xu
2012-11-23 8:45 ` Haojian Zhuang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN1soZy+JCfsroyUBFe9M_MW-sakcWwuqQMT5h0=+Haq+SJ5fw@mail.gmail.com' \
--to=haojian.zhuang@gmail.com \
--cc=cxie4@marvell.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=qingx@marvell.com \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).