From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B6221B9DA for ; Mon, 20 Oct 2025 03:13:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760930021; cv=none; b=hAud4OFR64Hs4MI0h0C7/XagqfojQrnp7M5IOTXyRNSpDuu7T8rJPTYVCrTfU/EUpMwqX/gIHdNIiOobmwvt3n/fzd8Lp4sQED3wfn2nE87ULmCFCpYE1AezLc7BRRt64YIVR/foNphvO7PboYCJMMSVUautnFnXWPVPoUrRtkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760930021; c=relaxed/simple; bh=kdv2StFd9t2aqx8yAzNqjNqEcQrRsIDibVmGkYKB12g=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=erlAS5kdsCY0tt7wel5X3QsviXjK40tjHMnXjTHXZQy7sunb3kXflJB7E5eFvDoZ1of7lE0N+QpEZYyKcJ0xx9BJPhHbG0p+ZEbjpJRXnyGqLp0SuQiMtlwt9fbEhnSuPOyWtb+usloYEJ4GJhlBEzhrUckC0fPvxnc7r3GXjQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jiHYX4CB; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jiHYX4CB" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-637e74e9104so5317550a12.1 for ; Sun, 19 Oct 2025 20:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760930018; x=1761534818; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=c5ZF0nIWQuoX7NVIe6I5+JsT65xxxmpn6kzl5bwhRQw=; b=jiHYX4CBMpFpAMpqf4Llbbfbajpj47ozqB9faFl74WVDNXJufbA6CfznmRa3NCrhVm szi8bmAyvH0aLA/p5qkD3Pf+hKtCgi1Go//lgeRZ+fCulfRpIS53l+JxsTjT0ZWEaTpl Y9vn1/xOhMOm+JDgToRQK22zHd/T5M12B6nEvhc3Y0MgryHLq50OI46FYHj1pZOdSGe4 4VkmuYG07UkhlbehpBrtxwRzOY4NDJm8OPNzzOGm6P93/fL5ZRpJVG52T6Owycv0F97P AH8hlHrzpBct5sQMT9XQvKJxUbwAXfN3o5CY33U5IZcA02BgXvUl8R4HEKegNUQcQK9u EPvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760930018; x=1761534818; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c5ZF0nIWQuoX7NVIe6I5+JsT65xxxmpn6kzl5bwhRQw=; b=Gv7TPqkyIW7S1HRK7BWFevYM5ia7KhBjJa0jh6HsYKv3GAZqqYy3ihdo+3916iIgyC xIIUiCmpHgWFiMxzcmcNYCcSseN7yYwIIjD2Ixu0J0SiIkEWnrMT9E6QMAQ1LxagssLj bg2BEyivAAvbiZg+ZHrdtU8XX2ayYjeFEepnQBV/kvSq9uHBlkGhobd35CPX+fVfIJXT ma4qGPpt/IRSDjxbXNLoB1Iboif+GGDRIoUJRcm3tqS1C613dLG5uiuhxB8OkRoRuzAH 7AMy8Z9J47oCwl+Y/1OYk7DzVg7qIrvJ8fToR6GW8mhOcIUTgctw0Yzv/ZSWyU4eZYdo MvuA== X-Forwarded-Encrypted: i=1; AJvYcCVJ05cGLjhhVt+GA7ZtnrRh5QOyH6Mo6veFyNZBlIO9lgVY7zzHZe8gNY7ca+mH9/NLr2UOlIGLe9UW@vger.kernel.org X-Gm-Message-State: AOJu0YxkLbYz6GNMfG7G2X+iMqzRyDs0VNhxFC1/lcGOj4IvJjSW6zoO /9nUFyFZZlxNHnjoAMnMyJDeXIaKaqnl6ozC2urN7GC3jCbvfrAMMOR28LKPkaYbtGUecg4/ZJb 3btkzGLpazxikSxldzGuq70raewrku04= X-Gm-Gg: ASbGncszMHZp7nx+/okC0lggOr6/ZgBHatKEheQOKyHx8KbA/mO8dtDtrbTNCQKEAOR cIQ+iATmTvWb7inK6PUwUcxfTfpDhZ2pYcapR4ECpPVgWejKIrpxm3+3i0VacvFD+xHsIwZR/4P ifx3w2jkXZqUwoQYLSK9PJFCHa5ZO8BqKA8766lkQJ0BP1u+RvqRRAd5rOel2Q6MgA02ziIZRU6 0FAo3rAp9VuA3wTXjZRmNCbiW+EecV5Y4TlS5WjmoYTK0taoaaq3l82Xws= X-Google-Smtp-Source: AGHT+IFlIM9veSfUiCEqCs4cu1zurxwbaOmQwJt6C38o77/S8LVLD6y47Rn4sx8fit0dIc30Wd0JSNIXuLu1cF7zy6g= X-Received: by 2002:a05:6402:278a:b0:63c:17f5:cc93 with SMTP id 4fb4d7f45d1cf-63c1f630f4emr10867390a12.8.1760930017243; Sun, 19 Oct 2025 20:13:37 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251017073954.130710-1-cnsztl@gmail.com> <7f0b1747-87eb-0b0b-6fb0-304811a4be21@manjaro.org> <41154cde-a447-0707-4387-cd3dca90b97d@manjaro.org> <47931e9e-09db-3909-4531-dae6869171d7@manjaro.org> <047fe2b8-0f94-0f0f-5964-b65844834706@manjaro.org> In-Reply-To: <047fe2b8-0f94-0f0f-5964-b65844834706@manjaro.org> From: Anand Moon Date: Mon, 20 Oct 2025 08:43:18 +0530 X-Gm-Features: AS18NWCj3sZ27S7v2lVifIDB-bfHc9CGVpcmzR6xkep1HgXpZq9MDT3bZH4TJtE Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: fix eMMC corruption on NanoPC-T6 with A3A444 chips To: Dragan Simic Cc: Hugh Cole-Baker , Jimmy Hon , Tianling Shen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Grzegorz Sterniczuk , Jonas Karlman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Dragan, On Sun, 19 Oct 2025 at 23:40, Dragan Simic wrote: > > Hello Anand, > > On Sunday, October 19, 2025 19:25 CEST, Anand Moon wrote: > > Would you consider the following patch? > > > > As per the Rockchip RK3588S SoC Technical Reference Manual (TRM) Part 1, > > chapter 21.6, Interface Description, the eMMC signals require careful handling > > to ensure signal integrity. > > > > I2C2_SCL_M2 I/O EMMC_RSTN/I2C2_SCL_M2/UART5_RTSN_M1/GPIO2_A3_d > > BUS_IOC_GPIO2A_IOMUX_SEL_L[15:12]=0x9 > > I2C2_SDA_M2 I/O EMMC_DATA_STROBE/I2C2_SDA_M2/UART5_CTSN_M1/GPIO2_A2_d > > BUS_IOC_GPIO2A_IOMUX_SEL_L[11:8]=0x9 > > > > $ git diff . > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi > > b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi > > index 6584d73660f6..f60a1d8be0ef 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi > > @@ -327,7 +327,7 @@ emmc { > > emmc_rstnout: emmc-rstnout { > > rockchip,pins = > > /* emmc_rstn */ > > - <2 RK_PA3 1 &pcfg_pull_none>; > > + <2 RK_PA3 1 &pcfg_pull_down_drv_level_2>; > > }; > > > > /omit-if-no-ref/ > > @@ -369,7 +369,7 @@ emmc_cmd: emmc-cmd { > > emmc_data_strobe: emmc-data-strobe { > > rockchip,pins = > > /* emmc_data_strobe */ > > - <2 RK_PA2 1 &pcfg_pull_down>; > > + <2 RK_PA2 1 &pcfg_pull_down_drv_level_2>; > > }; > > }; > > Frankly, I'm not really sure how would such changes do something > good regarding the eMMC signal integrity? In general, signal > integrity depends mostly on the routing of the PCB traces, which > is purely hardware design. Sure, termination of data lines also > plays a significant role, but that surely isn't at play here. > It is necessary to enhance the signal quality from the controller to the eMMC module > Moreover, the eMMC RSTn line is already pulled high to VCCIO in > the reference RK3588 design, so pulling it down in the SoC itself > would be pretty much wrong thing to do. > It is specified in the TRM that this is only applicable during initialization.as per my understanding. Thanks -Anand