Re: [PATCH v3 1/2] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node

[Anand Moon <linux.amoon@gmail.com>]

Hi Martin.

On Sun, 30 Aug 2020 at 19:34, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Anand,
>
> On Sun, Aug 30, 2020 at 3:12 PM Anand Moon <linux.amoon@gmail.com> wrote:
> [...]
> > +       /* Make sure the rtc irq pin is properly configured as input */
> > +       rtc_irq_pins: rtc-pin-irq {
> > +               mux {
> > +                       groups = "GPIOAO_7";
> > +                       function = "gpio_periphs";
> check meson_g12a_aobus_functions in drivers/pinctrl/meson/pinctrl-meson-g12a.c
> GPIOAO_7 doesn't support "gpio_periphs", instead I think it should be
> "gpio_aobus"
>
Thanks for this information, I really learned a lot on this feature..

> I'm surprised that you don't seem to be getting errors from the pin
> controller driver about this.
> On the other hand you have not attached the full kernel log, so maybe
> it's in there but hidden somewhere
>
> > +                       bias-disable;
> shouldn't there be output-disable or input-enable here?
>
Thanks for this information and correction.

> > +               };
> > +       };
> > +
> >         hdmi-connector {
> >                 compatible = "hdmi-connector";
> >                 type = "a";
> > @@ -481,7 +490,8 @@ hdmi_tx_tmds_out: endpoint {
> >
> >  &i2c3 {
> >         pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>;
> > -       pinctrl-names = "default";
> > +       pinctrl-1 = <&rtc_irq_pins>;
> > +       pinctrl-names = "default", "gpio_periphs";
> I am not expecting this to work because it means that the I2C driver
> would have to manage the "gpio_periphs" pin state (but there's no
> pinctrl_* call in drivers/i2c/busses/i2c-meson.c)
> instead I would try:
> &i2c3 {
>   pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>, <&rtc_irq_pins>;
>   pinctrl-names = "default";
>
>   ...
> };
>
> or even:
> rtc0: rtc@51 {
>   pinctrl-0 = <&rtc_irq_pins>;
>   pinctrl-names = "default";
>
>   ...
> };
>

Thanks for the input on the IRC,
I followed Neil's suggestion to work for me.

Best regards,
-Anand