From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C94AAC433E2 for ; Sun, 30 Aug 2020 20:06:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FC03208A9 for ; Sun, 30 Aug 2020 20:06:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tEcjKtkO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbgH3UGM (ORCPT ); Sun, 30 Aug 2020 16:06:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbgH3UGK (ORCPT ); Sun, 30 Aug 2020 16:06:10 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1A61C061573 for ; Sun, 30 Aug 2020 13:06:10 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id o16so4847450ilq.0 for ; Sun, 30 Aug 2020 13:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3z5XdXsgvD+nH7zCf5Gwtyiq31V0gPdWkz0sp8uWVaY=; b=tEcjKtkOLoWym+8QvlohWzXDduWWS4m9nWpY6QDnGvKIl4nyhUW04uniBLOhiW03nE mDr+nT6OiupIb+cAADY3pPB8c+YSVYEKKjOUmcXwPKjItjACnr9NXVaWhiGQYta47Gs6 64bnHSXKfygzzTsmibzszE7oUPafm7j7zmJsd+0aIn1Z4wKW7lz2TCUuGHh35yF2IyHz ONkQX/bRrAZma925jXwnTHVdr8ddC33RatYf6I5+PDke61vtNwO97b/GE0CBxhsPRh9W Ll8iS0bNDuxm31j94TL7CaetooRq7v5BFZqAWrWpmyzREGjo7Nbek34igYMIeJRv/ZIf 7TMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3z5XdXsgvD+nH7zCf5Gwtyiq31V0gPdWkz0sp8uWVaY=; b=dESeg3im8Z11kbY6MEX/2wHW5+sSCn+6N8oRMqA23nMU1H3YLkP9PGYX6wlHT3TaFs Jsedgs7QbQYLi5oX7P+CJnEo0KFbZfvDMYM13H1IRSAloxQZFNljiZQUjhj/Hajc/3Jx /eSKwAbYZE+lmxckEvuyyKSOKYcmmMtQsqwiAH+e3L19GTx7T1OYM65fVMOqiyKlGLo0 7eZ/RCvY/iJ3TB0rXffL546JzqiW5OJ6Ptf6jnWLz9abZA91heNz09DuSOIJ0rngQXKP z6g9lRVE4He+XFEz1If4ZO6MZ1FrC9z1kESg5sIpr4quq0mMocPwtAgYdY3QOQ21XuqL NO2Q== X-Gm-Message-State: AOAM53379QLevjBTdhjC22/sk12d05CQ9d9IXvUpmnMK2gHGo1eb1cvF fRy0pQwppAjRxxDfw2QgofyIHCWKpBjJyx4S0Rk= X-Google-Smtp-Source: ABdhPJy2xzukOmZ6jrpihqoZ6Lo/wS1efaLMrUJNQstm/cK3YHqa5tts6ZqEA3sNyC5n2UPVnXv+3lEim//csX/BZsQ= X-Received: by 2002:a92:d8cb:: with SMTP id l11mr6141767ilo.221.1598817970039; Sun, 30 Aug 2020 13:06:10 -0700 (PDT) MIME-Version: 1.0 References: <20200820121323.564-1-linux.amoon@gmail.com> <20200820121323.564-2-linux.amoon@gmail.com> <7hlfi9xgch.fsf@baylibre.com> <1j7dto3ylq.fsf@starbuckisacylon.baylibre.com> <1j4koq4x38.fsf@starbuckisacylon.baylibre.com> In-Reply-To: From: Anand Moon Date: Mon, 31 Aug 2020 01:35:58 +0530 Message-ID: Subject: Re: [PATCH v3 1/2] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node To: Martin Blumenstingl Cc: Jerome Brunet , Neil Armstrong , Kevin Hilman , devicetree , linux-arm-kernel , linux-amlogic@lists.infradead.org, Rob Herring , Christian Hewitt Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Martin. On Sun, 30 Aug 2020 at 19:34, Martin Blumenstingl wrote: > > Hi Anand, > > On Sun, Aug 30, 2020 at 3:12 PM Anand Moon wrote: > [...] > > + /* Make sure the rtc irq pin is properly configured as input */ > > + rtc_irq_pins: rtc-pin-irq { > > + mux { > > + groups = "GPIOAO_7"; > > + function = "gpio_periphs"; > check meson_g12a_aobus_functions in drivers/pinctrl/meson/pinctrl-meson-g12a.c > GPIOAO_7 doesn't support "gpio_periphs", instead I think it should be > "gpio_aobus" > Thanks for this information, I really learned a lot on this feature.. > I'm surprised that you don't seem to be getting errors from the pin > controller driver about this. > On the other hand you have not attached the full kernel log, so maybe > it's in there but hidden somewhere > > > + bias-disable; > shouldn't there be output-disable or input-enable here? > Thanks for this information and correction. > > + }; > > + }; > > + > > hdmi-connector { > > compatible = "hdmi-connector"; > > type = "a"; > > @@ -481,7 +490,8 @@ hdmi_tx_tmds_out: endpoint { > > > > &i2c3 { > > pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>; > > - pinctrl-names = "default"; > > + pinctrl-1 = <&rtc_irq_pins>; > > + pinctrl-names = "default", "gpio_periphs"; > I am not expecting this to work because it means that the I2C driver > would have to manage the "gpio_periphs" pin state (but there's no > pinctrl_* call in drivers/i2c/busses/i2c-meson.c) > instead I would try: > &i2c3 { > pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>, <&rtc_irq_pins>; > pinctrl-names = "default"; > > ... > }; > > or even: > rtc0: rtc@51 { > pinctrl-0 = <&rtc_irq_pins>; > pinctrl-names = "default"; > > ... > }; > Thanks for the input on the IRC, I followed Neil's suggestion to work for me. Best regards, -Anand