devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-amlogic@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCHv1 2/3] arm64: dts: meson-g12b-odroid-n2: Disable virtual wake RTC
Date: Thu, 16 Jul 2020 12:49:20 +0530	[thread overview]
Message-ID: <CANAwSgTkFd0P0zJ48AVRWB4roQHsLainzypokYOD+L4v6gbGxw@mail.gmail.com> (raw)
In-Reply-To: <630df1a7-8809-1af2-e424-8190a503a9d6@baylibre.com>

Hi Neil,

Thanks for your review comments.

On Thu, 16 Jul 2020 at 12:35, Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi,
>
> On 15/07/2020 18:02, Anand Moon wrote:
> > Disable virtual wake RTC node on Odroid N2.
> >
> > [    7.171149] meson-vrtc ff8000a8.rtc: registered as rtc0
> > [    7.182875] meson-vrtc ff8000a8.rtc: setting system clock to 1970-01-01T00:00:07 UTC (7)
> >
> > Cc: Neil Armstrong <narmstrong@baylibre.com>
> > Cc: Kevin Hilman <khilman@baylibre.com>
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> > ---
> >  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > index a447cba4dd53..c8c1262a7bfc 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > @@ -517,3 +517,7 @@ &usb2_phy1 {
> >       /* Enable the hub which is connected to this port */
> >       phy-supply = <&hub_5v>;
> >  };
> > +
> > +&vrtc {
> > +     status = "disabled";
> > +};
> >
>
> Please don't, the vrtc is here to wake up the device.
>
> Neil

Ok, I thought that there would be conflicts with the RTC module,
that's why I disable this node. I will drop this patch.

-Anand

  reply	other threads:[~2020-07-16  7:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 16:02 [PATCHv1 0/3] Enable RTC on Odroid N2 Anand Moon
2020-07-15 16:02 ` [PATCHv1 1/3] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node Anand Moon
2020-07-16  7:08   ` Neil Armstrong
2020-07-16  8:02     ` Anand Moon
2020-07-16  8:08   ` Jerome Brunet
2020-07-16  9:12     ` Anand Moon
2020-07-15 16:02 ` [PATCHv1 2/3] arm64: dts: meson-g12b-odroid-n2: Disable virtual wake RTC Anand Moon
2020-07-16  7:05   ` Neil Armstrong
2020-07-16  7:19     ` Anand Moon [this message]
2020-07-15 16:02 ` [PATCHv1 3/3] arm64: defconfig: Enable RTC devices for Amlogic boards Anand Moon
2020-07-16  7:08   ` Neil Armstrong
2020-07-16  7:05 ` [PATCHv1 0/3] Enable RTC on Odroid N2 Neil Armstrong
2020-07-16  8:14   ` Anand Moon
2020-07-16  8:20     ` Neil Armstrong
2020-07-16  8:35       ` Neil Armstrong
2020-07-16 15:42         ` Anand Moon
2020-07-16 21:28         ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANAwSgTkFd0P0zJ48AVRWB4roQHsLainzypokYOD+L4v6gbGxw@mail.gmail.com \
    --to=linux.amoon@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).