From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bo39MrV6" Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9181210F8; Fri, 8 Dec 2023 03:20:14 -0800 (PST) Received: by mail-oi1-x234.google.com with SMTP id 5614622812f47-3b8952b8066so1438234b6e.1; Fri, 08 Dec 2023 03:20:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702034414; x=1702639214; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2PEUKU4RsP0giZMZ/KrfzmNAgaL4v7lal6pj/aFK5ok=; b=bo39MrV6ixg+FyNnNatPV6NNiRPj8FY6U9wk69IqZqiKiKTVRXOc9iWxzuu0LAiDxa 61jX8cOAUwSAzudeNE6tyTeLikODrbgACAw5PC+sP+StFTi2OdH0vDVeQWYG7N2K32Iv VJuc+g8teUJx5q6oPbPJ78uU9TXQUTz4d1zyEgNsGUoZx8TYyTBRFqroOZi22PEzNBql woqj0epjWK0eUQX+bXq9rnEJGZVclv7MyUVd7zIxelInqhTcRIqFDGd9jc0xfR+f/Q13 bskZ5chgEUMk6ipVQyo8nwq9KbA4GjhqfqeKmml8i2R9gKLXZPIaD5PSSSM3x+Bjjf54 LhEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702034414; x=1702639214; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2PEUKU4RsP0giZMZ/KrfzmNAgaL4v7lal6pj/aFK5ok=; b=i1tLc/eaB1saYnzJNEqcSv646MDw10fF8LBBtdeoKhh6nuhnFqtSW2Em88W/ryalXA +YRt00E0mvZFBHnKM+09jjV+6lWO1AlNSpBcUczGZElaJdvfMMpKUg5pmCfuRDqr6UqR Nd62V5xCfwf9AkRHmrIRDsDiYkrntC3zFyDIvsWRkclVo2TaaVRSqz+VhQaG0JrNAgX8 gBnKXMP2Ei9LRe/3kciMEJ5nWLBSU5siJ2uis4U0Xph6EbkTZMhDzyW0vAZidT8NN11/ sr8gMTrywTJd8HSKRcdrLYc31DE2bRfJrqCn59UeGQXE40utWE9ebLZg6cfF/FSZjZwd JHTg== X-Gm-Message-State: AOJu0YwBTVOIZFbiRZC5eBd9d3aGQKP+S7FThhu/HcKbDXY7zYpylA2I o/gF/xx008Jnlu090fnXvR1Jniko3xy5ZkPOoHg= X-Google-Smtp-Source: AGHT+IHKfgOJJkGUVNVFohMebN1Pi1RObECe1iqnsd4pbG5YaF8nQXN5FgdG0fJYIqAU9y4NJPN/aM1KEVAfQ33/aHk= X-Received: by 2002:a05:6808:640c:b0:3b9:d2ea:4d2 with SMTP id fg12-20020a056808640c00b003b9d2ea04d2mr327428oib.22.1702034413856; Fri, 08 Dec 2023 03:20:13 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231204144429.45197-1-linux.amoon@gmail.com> <20231204144429.45197-2-linux.amoon@gmail.com> <20231206135311.GA2043711-robh@kernel.org> <21673bfd-bb87-4c7d-a53f-337c263f3a00@linaro.org> <604e653d-c1e2-45c7-b121-8a6b4be5c6bb@linaro.org> <1a78d453-62a2-410a-a40f-1ff0c2b62e86@linaro.org> In-Reply-To: <1a78d453-62a2-410a-a40f-1ff0c2b62e86@linaro.org> From: Anand Moon Date: Fri, 8 Dec 2023 16:49:57 +0530 Message-ID: Subject: Re: [PATCH v6 1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub To: Krzysztof Kozlowski Cc: Rob Herring , Greg Kroah-Hartman , Krzysztof Kozlowski , Conor Dooley , Icenowy Zheng , Neil Armstrong , linux-amlogic@lists.infradead.org, Conor Dooley , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Krzysztof, On Fri, 8 Dec 2023 at 13:14, Krzysztof Kozlowski wrote: > > On 08/12/2023 01:24, Anand Moon wrote: > >>>>> > >>>>> If I move reset-gpios to required, I observe the below warning. > >>>>> > >>>>> DTC_CHK Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb > >>>>> /home/alarm/linux-amlogic-5.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb: > >>>>> hub@1: 'reset-gpio' is a required property > >>>>> from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# > >>>> > >>>> Where are the properties defined? If you open the binding you see: > >>>> nowhere. You cannot define properties in some variant with "true". > >>>> Please define all of them in top-level and only narrow/constrain when > >>>> applicable. > >>>> > >>> What I meant is the example below, required meant applicable for both > >>> the binding > >>> But it shows me the above warning. > >> > >> My explanation stands... So again: > >> > >>>> Please define all of them in top-level and only narrow/constrain when > >>>> applicable. > >> > > Apologies, But I have tried this multiple times but have not been able > > to fix the device tree warning > > Did you document all properties in top-level "properties:" block? > Yes, I have, Can you suggest a couple of examples to follow? I looked at some of the YAML files but could not fix my issue. Thanks -Anand