From: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: tiwai@suse.com, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
ukleinek@kernel.org, krzk+dt@kernel.org,
dmitry.torokhov@gmail.com, broonie@kernel.org,
linux-pwm@vger.kernel.org, lee@kernel.org,
linux-sound@vger.kernel.org, lgirdwood@gmail.com,
peter.ujfalusi@gmail.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, shuah@kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH 2/8] mfd: dt-bindings: ti,twl6040: convert to DT schema
Date: Tue, 12 Aug 2025 18:06:53 +0200 [thread overview]
Message-ID: <CANBuOYrCAcgp+x+TL98V3ih_ThyPF7x6VgXxVi4YnAdOC3nZvA@mail.gmail.com> (raw)
In-Reply-To: <20250812145415.GA3607226-robh@kernel.org>
On Tue, Aug 12, 2025 at 4:54 PM Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Aug 11, 2025 at 08:24:43PM -0500, Rob Herring (Arm) wrote:
> >
> > On Tue, 12 Aug 2025 00:47:33 +0200, Jihed Chaibi wrote:
> > > Convert the legacy TXT binding for the TWL6040 MFD
> > > to the modern YAML DT schema format. This adds formal validation
> > > and improves documentation.
> > >
> > > Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
> > > ---
> > > .../devicetree/bindings/mfd/ti,twl6040.yaml | 155 ++++++++++++++++++
> > > .../devicetree/bindings/mfd/twl6040.txt | 67 --------
> > > 2 files changed, 155 insertions(+), 67 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/mfd/ti,twl6040.yaml
> > > delete mode 100644 Documentation/devicetree/bindings/mfd/twl6040.txt
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,twl6040.example.dtb:
> > twl@4b (ti,twl6040): 'twl6040,audpwron-gpio' does not match any of
> > the regexes: '^#.*',
> > '^(at25|bm|devbus|dmacap|dsa|exynos|fsi[ab]|gpio-fan|gpio-key|gpio|gpmc|hdmi|i2c-gpio),.*',
> > '^(keypad|m25p|max8952|max8997|max8998|mpmc),.*',
> > '^(pciclass|pinctrl-single|#pinctrl-single|PowerPC),.*',
> > '^(pl022|pxa-mmc|rcar_sound|rotary-encoder|s5m8767|sdhci),.*',
> > '^(simple-audio-card|st-plgpio|st-spics|ts),.*',
>
> You will need to add 'twl6040' to this list of exceptions in
> vendor-prefixes.yaml.
>
> Rob
Hi Rob, thanks for the feedback.
Wouldn't it be simpler if we put 'ti' (the actual vendor) instead of 'twl6040'?
No other file is using the current name, so there would be no need for
additional editing.
Cheers,
(CCing everyone, sorry for emailing twice)
next prev parent reply other threads:[~2025-08-12 16:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 22:47 [PATCH 0/8] dt-bindings: Convert TWL4030/6040 family binding to DT schema Jihed Chaibi
2025-08-11 22:47 ` [PATCH 1/8] mfd: dt-bindings: ti,twl4030-audio: convert " Jihed Chaibi
2025-08-12 14:58 ` Rob Herring
2025-08-11 22:47 ` [PATCH 2/8] mfd: dt-bindings: ti,twl6040: " Jihed Chaibi
2025-08-12 1:24 ` Rob Herring (Arm)
2025-08-12 14:54 ` Rob Herring
2025-08-12 16:06 ` Jihed Chaibi [this message]
2025-08-14 21:24 ` Rob Herring
2025-08-11 22:47 ` [PATCH 3/8] input: dt-bindings: ti,twl4030-keypad: " Jihed Chaibi
2025-08-11 22:47 ` [PATCH 4/8] mfd: dt-bindings: ti,twl4030-power: " Jihed Chaibi
2025-08-11 22:47 ` [PATCH 5/8] pwm: dt-bindings: ti,twl-pwm: " Jihed Chaibi
2025-08-19 6:08 ` Uwe Kleine-König
2025-08-11 22:47 ` [PATCH 6/8] pwm: dt-bindings: ti,twl-pwmled: " Jihed Chaibi
2025-08-11 22:47 ` [PATCH 7/8] sound: dt-bindings: ti,omap-twl4030: " Jihed Chaibi
2025-08-13 20:29 ` Mark Brown
2025-08-18 18:03 ` Rob Herring
2025-08-11 22:47 ` [PATCH 8/8] usb: dt-bindings: ti,twlxxxx-usb: " Jihed Chaibi
2025-08-19 6:09 ` [PATCH 0/8] dt-bindings: Convert TWL4030/6040 family binding " Uwe Kleine-König
2025-08-19 13:19 ` Jihed Chaibi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANBuOYrCAcgp+x+TL98V3ih_ThyPF7x6VgXxVi4YnAdOC3nZvA@mail.gmail.com \
--to=jihed.chaibi.dev@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=robh@kernel.org \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).