devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Mayer <code-7CzEARzsJhSsTnJN9+BGXg@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Florian Fainelli
	<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Device Tree List <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Enumerating multiple devices of the same kind
Date: Fri, 12 May 2017 16:28:45 -0700	[thread overview]
Message-ID: <CANEuBv5+94On4oxKzOJBKC_Gi6ycJwtUEb477d3ZcnxFOVCe-w@mail.gmail.com> (raw)

Hi all,

We are in the position of needing to enumerate multiple devices of the
same kind in device tree. I was originally thinking to just use
"index". Florian pointed out that "cell-index" seemed to be what was
being used by others. I submitted that upstream. Rob subsequently
pointed out that cell-index is "not a valid property for FDT (only
real OpenFirmware)."

The whole thread is archived here: https://patchwork.kernel.org/patch/9686283/.

The driver has since been converted into a SoC driver (no longer part
of the hwmon subsystem) and the cell-index property has been removed
from the binding. I'll be sending all that out for upstreaming in the
near future.

The reworked binding now looks like this:

       dpfe_cpu0: dpfe-cpu@f1132000 {
               compatible = "brcm,bcm7271-dpfe-cpu", "brcm,dpfe-cpu";
               reg =  <0xf1132000 0x180
                       0xf1134000 0x1000
                       0xf1138000 0x4000>;
               reg-names = "dpfe-cpu", "dpfe-dmem", "dpfe-imem";
       };

We still need some form of index, however, since we do have SoCs that
have more than one such node. What would be the preferred approach to
include such an index in the node?

Thanks,
-Markus
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

                 reply	other threads:[~2017-05-12 23:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANEuBv5+94On4oxKzOJBKC_Gi6ycJwtUEb477d3ZcnxFOVCe-w@mail.gmail.com \
    --to=code-7czearzsjhsstnjn9+bgxg@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).