From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FBFC433E0 for ; Wed, 3 Feb 2021 04:04:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FE0064DE8 for ; Wed, 3 Feb 2021 04:04:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231723AbhBCEDv (ORCPT ); Tue, 2 Feb 2021 23:03:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231320AbhBCEDv (ORCPT ); Tue, 2 Feb 2021 23:03:51 -0500 Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A7C4C06174A for ; Tue, 2 Feb 2021 20:03:09 -0800 (PST) Received: by mail-ua1-x930.google.com with SMTP id d3so7883346uap.4 for ; Tue, 02 Feb 2021 20:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rRmcBS+D8ie4DR9UuABqvgaIR3BnrLM49K5MwM/jb2k=; b=Cnkmlci4Z9x+W9PJgvly/S+T/Xk7q2JAM0NOGhqlpC7cCWxjELth6QexjoNksXnl6A 8s+rwaY5mTIEe4ADvKzRHYkx7aSYUlCpD4R4kj0eZ4g0FW05K0f+7JiWwws/L8HU0LbI nMCwrt8I+1VHLGlwxeOCno6OZ/UhCde+lxvCI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rRmcBS+D8ie4DR9UuABqvgaIR3BnrLM49K5MwM/jb2k=; b=h+C+7+ILFELcAkOtLJYZW/JqEmISp1Jyx9S++IapqPWTxcSLYB5uDAY3U47s4zzt6z c71cp0845nsCKARbqVlXS4hvKtH0/uAld8dx8FCj7Gtyf5ZjgYjx0uH2CVjyRbSaSyBL diCM9nANJ+KIcYwGYRkWdHkCH4eIEollR2cRhAarBGTfNG/nup/qWxdDKqj3FDF5znZG myIJE98Tf3UG/h8AiQudMu6eOb/uzqDGrJeNN/JLnfz0APtWoITPWCKTCGG+nYLDPQ3u jiad3BYlCw36alLSlHDgy+YT9oJ6K9KXGjdLvNP1MPLqlx1BDFDh8XQ7TO2MYzApII7c Gf9g== X-Gm-Message-State: AOAM530Hqaa++hvz1KrIVVSR9hlzxd2uKWpF7EoZHYSFUdaeIZLxQpSY IVakPWNtSJOKAwmdlCp0qMZ6PKLpMghl2BeOhI24eQ== X-Google-Smtp-Source: ABdhPJzKgdO699d7NEidKkYUFGCitxzY1h0GLirMYgqHTXBy0DPlWTL+v/D9UP+CXksw/KwcJdfdGHR++aPPOFRquR8= X-Received: by 2002:ab0:3043:: with SMTP id x3mr748227ual.88.1612324988471; Tue, 02 Feb 2021 20:03:08 -0800 (PST) MIME-Version: 1.0 References: <20210201034755.15793-1-jitao.shi@mediatek.com> In-Reply-To: <20210201034755.15793-1-jitao.shi@mediatek.com> From: Nicolas Boichat Date: Wed, 3 Feb 2021 12:02:57 +0800 Message-ID: Subject: Re: [PATCH] drm/mediatek: fine tune the data lane trail by project dts To: Jitao Shi Cc: Rob Herring , Mark Rutland , Matthias Brugger , Daniel Vetter , David Airlie , dri-devel , lkml , Devicetree List , srv_heupstream , huijuan.xie@mediatek.com, stonea168@163.com, cawa cheng , shuijing.li@mediatek.com, "moderated list:ARM/Mediatek SoC support" , Yingjoe Chen , Eddie Huang , linux-arm Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Feb 1, 2021 at 11:48 AM Jitao Shi wrote: > > Some panels or bridges require customized hs_da_trail time. > So add a property in devicetree for this panels and bridges. Since this changes the device tree, you also need to upload a binding document change. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 8c70ec39bfe1..6e7092fa2fee 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -194,6 +194,7 @@ struct mtk_dsi { > struct clk *hs_clk; > > u32 data_rate; > + u32 da_trail_delta; > > unsigned long mode_flags; > enum mipi_dsi_pixel_format format; > @@ -234,7 +235,7 @@ static void mtk_dsi_phy_timconfig(struct mtk_dsi *dsi) > timing->da_hs_prepare = (80 * data_rate_mhz + 4 * 1000) / 8000; > timing->da_hs_zero = (170 * data_rate_mhz + 10 * 1000) / 8000 + 1 - > timing->da_hs_prepare; > - timing->da_hs_trail = timing->da_hs_prepare + 1; > + timing->da_hs_trail = timing->da_hs_prepare + 1 + dsi->da_trail_delta; > > timing->ta_go = 4 * timing->lpx - 2; > timing->ta_sure = timing->lpx + 2; > @@ -1094,6 +1095,13 @@ static int mtk_dsi_probe(struct platform_device *pdev) > goto err_unregister_host; > } > > + ret = of_property_read_u32_index(dev->of_node, "da_trail_delta", 0, > + &dsi->da_trail_delta); > + if (ret) { > + dev_info(dev, "Can't get da_trail_delta, keep it as 0: %d\n", ret); > + dsi->da_trail_delta = 0; > + } > + > comp_id = mtk_ddp_comp_get_id(dev->of_node, MTK_DSI); > if (comp_id < 0) { > dev_err(dev, "Failed to identify by alias: %d\n", comp_id); > -- > 2.12.5 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel