From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F25C3F68F for ; Mon, 13 Jan 2020 06:20:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2926A20678 for ; Mon, 13 Jan 2020 06:20:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WxS0Vug8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733277AbgAMGUm (ORCPT ); Mon, 13 Jan 2020 01:20:42 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:40850 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725909AbgAMGUm (ORCPT ); Mon, 13 Jan 2020 01:20:42 -0500 Received: by mail-qk1-f196.google.com with SMTP id c17so7529062qkg.7 for ; Sun, 12 Jan 2020 22:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rbidIxb647dakpGFJlRyQ3/ihwOOmZc8NjZm9uAOe7Y=; b=WxS0Vug8xhyLR97I/t2SZL6RKMcPSykb1/Bq9crc1+OYZoBfukLaCJ9Tc9EkP/uu4X Z/um91CPIbStVhvRelpbdaq1iHMzd7+XSjtZ8VepD8xsTX0rMGUdOyTvMt7hl6oHtKMp 1B6kNdZiMwE4Ii6DDhLJyCHRDlv0pDydLfxB8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rbidIxb647dakpGFJlRyQ3/ihwOOmZc8NjZm9uAOe7Y=; b=s5Zk0LYCyrnWmoz31VGdVMvsBoNUElEl/BHRyVhfXkYX1EIjTTXgRmUl5/nNv05jpt 4dbMc2uvUquYeEiey1425GpU2+XpJLCPWRsvHTFZutxVnD4glPQ9h+96+ix/PkcZwBSs 9H39Yimt88ji0fGrlB33ETWOx3FbSD0+OQeisuAhsm2VXDq5H8x1IF8xD6NRR1R9WIrI u4G4HXZdmqm2nooyCorT3ehlxmzMDXdWKd9+sUah9oY6sqrZ2TgJU/Lt+of9Irpa0xxh UCFHP2kyeyWmzEXgoJa54jfeyF1OFG1vNJj60RtxzW4oqGrrvMo0Rv4CdG/OohtndfTz cXZQ== X-Gm-Message-State: APjAAAWO5fIp5TZ/m31L9J5nPIWisAM/ErvshB2d+pk25S/0qu6Y34WZ y2pOSW6nERGdQR7kJE8qtXCZcYmn5/X4CtJFFsySg+oE X-Google-Smtp-Source: APXvYqyg+DfzeIRu42KEs7ygYGGHEH4ohvCGoNjEgPqdFrdCkhfaR1L7mh+JsDSUmfVNYFE5Ptt8z7b4B+RTP5IqduA= X-Received: by 2002:a05:620a:6d7:: with SMTP id 23mr14062530qky.299.1578896440489; Sun, 12 Jan 2020 22:20:40 -0800 (PST) MIME-Version: 1.0 References: <1578639862-14480-1-git-send-email-jiaxin.yu@mediatek.com> <1578639862-14480-4-git-send-email-jiaxin.yu@mediatek.com> In-Reply-To: <1578639862-14480-4-git-send-email-jiaxin.yu@mediatek.com> From: Nicolas Boichat Date: Mon, 13 Jan 2020 14:20:29 +0800 Message-ID: Subject: Re: [PATCH v11 3/3] watchdog: mtk_wdt: mt2712: Add reset controller To: Jiaxin Yu Cc: Yong Liang , wim@linux-watchdog.org, linux@roeck-us.net, Philipp Zabel , Matthias Brugger , linux-watchdog@vger.kernel.org, lkml , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Devicetree List , chang-an.chen@mediatek.com, freddy.hsin@mediatek.com, Yingjoe Chen , Stephen Boyd Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jan 10, 2020 at 3:04 PM Jiaxin Yu wrote: > > Add reset controller for 2712. > Besides watchdog, MTK toprgu module alsa provide sub-system (eg, audio, > camera, codec and connectivity) software reset functionality. > > Signed-off-by: yong.liang > Signed-off-by: Jiaxin Yu > Reviewed-by: Yingjoe Chen > Reviewed-by: Philipp Zabel This is somewhat ok I guess, as Philipp review the same code before you split it into 2 patches. > Reviewed-by: Rob Herring > Reviewed-by: Guenter Roeck Those 2 need to be dropped. > --- > drivers/watchdog/mtk_wdt.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c > index e88aacb0404d..d6a6393f609d 100644 > --- a/drivers/watchdog/mtk_wdt.c > +++ b/drivers/watchdog/mtk_wdt.c > @@ -9,6 +9,7 @@ > * Based on sunxi_wdt.c > */ > > +#include > #include > #include > #include > @@ -67,6 +68,10 @@ struct mtk_wdt_data { > int toprgu_sw_rst_num; > }; > > +static const struct mtk_wdt_data mt2712_data = { > + .toprgu_sw_rst_num = MT2712_TOPRGU_SW_RST_NUM, > +}; > + > static const struct mtk_wdt_data mt8183_data = { > .toprgu_sw_rst_num = MT8183_TOPRGU_SW_RST_NUM, > }; > @@ -314,6 +319,7 @@ static int mtk_wdt_resume(struct device *dev) > #endif > > static const struct of_device_id mtk_wdt_dt_ids[] = { > + { .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data }, > { .compatible = "mediatek,mt6589-wdt" }, > { .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data }, > { /* sentinel */ } > -- > 2.18.0