From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Markuss Broks <markuss.broks@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/4] dt-bindings: regulator: Add bindings for Silicon Mitus SM5703 regulators
Date: Fri, 22 Apr 2022 21:37:20 +0300 [thread overview]
Message-ID: <CANhJrGPXJYf4Bf3oBLGB2v3AwyvJbompjX34qOaKXsEhFda0zw@mail.gmail.com> (raw)
In-Reply-To: <Yl8Jm9XqR3YTrW9Y@sirena.org.uk>
On Fri, Apr 22, 2022 at 9:05 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Apr 19, 2022 at 08:45:07PM +0300, Markuss Broks wrote:
>
> > I took an example from the rohm,bd71847-pmic.yaml MFD binding, they have
> > regulators at a separate regulators { } node, with a separate dt-binding for
> > it. I'm not sure what should I do, I'd be more than happy to follow a better
> > example if you can show me it.
>
> Basically either just remove the compatible and have the MFD directly
> instantiate the device like sky81452 or put a separate node for each
> regualtor like wm831x does (but without any DT support).
Just a note that the BD71847 does not have own "compatible" for the
regulators. There's only "compatible" in the MFD node - and MFD just
kicks the regulator driver. Regulators get the handle to the node from
the parent device. I think it should serve as a valid example of what
Mark described as
> Basically either just remove the compatible and have the MFD directly
> instantiate the device
Best Regards
-- Matti Vaittinen
next prev parent reply other threads:[~2022-04-22 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 16:00 [PATCH v4 0/4] Add support for Silicon Mitus SM5703 MFD Markuss Broks
2022-04-19 16:00 ` [PATCH v4 1/4] dt-bindings: regulator: Add bindings for Silicon Mitus SM5703 regulators Markuss Broks
2022-04-19 16:56 ` Mark Brown
2022-04-19 17:45 ` Markuss Broks
2022-04-19 19:12 ` Mark Brown
2022-04-22 18:37 ` Matti Vaittinen [this message]
2022-04-22 18:33 ` Matti Vaittinen
2022-04-19 16:00 ` [PATCH v4 2/4] dt-bindings: mfd: Add bindings for Silicon Mitus SM5703 MFD Markuss Broks
2022-04-20 1:19 ` Rob Herring
2022-04-19 16:00 ` [PATCH v4 3/4] mfd: sm5703: Add support for " Markuss Broks
2022-04-19 16:00 ` [PATCH v4 4/4] regulator: sm5703-regulator: Add regulators " Markuss Broks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANhJrGPXJYf4Bf3oBLGB2v3AwyvJbompjX34qOaKXsEhFda0zw@mail.gmail.com \
--to=mazziesaccount@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).