Re: [PATCH v2 03/07] ARM: shmobile: Add APMU nodes to r8a7790 DTSI

[Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Hi Laurent,

On Tue, Aug 25, 2015 at 3:29 AM, Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> wrote:
> Hi Magnus,
>
> Thank you for the patch.
>
> On Sunday 23 August 2015 16:25:00 Magnus Damm wrote:
>> From: Magnus Damm <damm+renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org>
>>
>> Add an APMU DT node for the r8a7790 SoC and use the enable-method to
>> point out that the APMU should be used for SMP support.
>>
>> Signed-off-by: Magnus Damm <damm+renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org>
>> ---
>>
>>  Changes from V1:
>>  - New patch
>>
>>  arch/arm/boot/dts/r8a7790.dtsi |   13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> --- 0001/arch/arm/boot/dts/r8a7790.dtsi
>> +++ work/arch/arm/boot/dts/r8a7790.dtsi       2015-08-23 15:51:24.132366518 +0900
>> @@ -43,6 +43,7 @@
>>       cpus {
>>               #address-cells = <1>;
>>               #size-cells = <0>;
>> +             enable-method = "renesas,apmu";
>>
>>               cpu0: cpu@0 {
>>                       device_type = "cpu";
>> @@ -112,6 +113,18 @@
>>               };
>>       };
>>
>> +     apmu@e6151000 {
>> +             compatible = "renesas,apmu-r8a7790", "renesas,apmu";
>> +             reg = <0 0xe6151000 0 0x188>;
>> +             cpus = <&cpu4 &cpu5 &cpu6 &cpu7>;
>> +     };
>> +
>> +     apmu@e6152000 {
>> +             compatible = "renesas,apmu-r8a7790", "renesas,apmu";
>> +             reg = <0 0xe6152000 0 0x188>;
>> +             cpus = <&cpu0 &cpu1 &cpu2 &cpu3>;
>> +     };
>
> I wonder whether those two nodes shouldn't be moved inside the CPG node as it
> seems that the APMU is part of the CPG IP core. We can delay that though, as
> the Gen3 DTS will need to be refactored anyway.

Hm, I don't mind reworking things, but with power domain focus I sort
of expected the APMU to be closer to SYSC than the CPG actually...

Thanks,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html