From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Damm Subject: Re: [PATCH 2/5] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Date: Mon, 17 Feb 2014 19:11:14 +0900 Message-ID: References: <1392543658-5030-1-git-send-email-wsa@the-dreams.de> <1392543658-5030-3-git-send-email-wsa@the-dreams.de> <20140217075410.GA2633@katana> <20140217091900.GD2633@katana> <20140217093126.GE2633@katana> <20140217100807.GA4424@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <20140217100807.GA4424@katana> Sender: linux-sh-owner@vger.kernel.org To: Wolfram Sang Cc: Geert Uytterhoeven , SH-Linux , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Simon Horman List-Id: devicetree@vger.kernel.org On Mon, Feb 17, 2014 at 7:08 PM, Wolfram Sang wrote: > >> It won't break because anyone who modifies r8a7790 support need to >> make it specific to that SoC to not pull in r8a7791 into some >> assumption. > > Geert's assumption was that exactly this can be forgotten. While this is > true, my point was that this is a bug. And as it turned out, neither > this or that solution helps the case :) It needs to be fixed or done > properly right from the beginning. > >> realize that there is no shortcut for adding the compatible string to >> the driver. It has to be done sooner or later anyway. > > OK, can be seen this way. As said before, I'll resend. Thanks! I'd be happy to discuss this more over a beverage in the not so distant future! =) / magnus