From mboxrd@z Thu Jan  1 00:00:00 1970
From: Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 02/04] ARM: shmobile: Add APMU DT support via Enable method
Date: Sun, 23 Aug 2015 16:23:17 +0900
Message-ID: <CANqRtoTm0-K-Tk0Js8_TSNNWhX84FHNxQ1gAUXB0LBgfG8dJow@mail.gmail.com>
References: <20150521012138.25972.91336.sendpatchset@little-apple>
	<20150521012200.25972.64826.sendpatchset@little-apple>
	<CAMuHMdXwMB17YXpqR9xr07vPg84CQL3W1Q20+gL+JvFEpOt+5Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <linux-sh-owner@vger.kernel.org>
In-Reply-To: <CAMuHMdXwMB17YXpqR9xr07vPg84CQL3W1Q20+gL+JvFEpOt+5Q@mail.gmail.com>
Sender: linux-sh-owner@vger.kernel.org
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-sh list <linux-sh@vger.kernel.org>, Mark Rutland <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, =?UTF-8?B?5bCP5p6X5pWs5aSq?= <keita.kobayashi.ym@renesas.com>, Simon Horman <horms@verge.net.au>
List-Id: devicetree@vger.kernel.org

Hi Geert,

On Thu, May 21, 2015 at 5:13 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, May 21, 2015 at 3:22 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> --- 0001/arch/arm/mach-shmobile/platsmp-apmu.c
>> +++ work/arch/arm/mach-shmobile/platsmp-apmu.c  2015-05-20 22:26:43.152366518 +0900
>
>> +static void apmu_parse_dt(void (*fn)(struct resource *res, int cpu, int bit))
>> +{
>> +       struct device_node *np_apmu, *np_cpu;
>> +       struct resource res;
>> +       u32 id;
>> +       int bit, index;
>> +       bool is_allowed;
>> +
>> +       for_each_matching_node(np_apmu, apmu_ids) {
>> +               /* only enable the cluster that includes the boot CPU */
>> +               is_allowed = false;
>
> You can declare the variable here instead of at the top of the function.

Sure, good idea.

>> +               for (bit = 0; bit < CONFIG_NR_CPUS; bit++) {
>> +                       np_cpu = of_parse_phandle(np_apmu, "cpus", bit);
>> +                       if (np_cpu) {
>> +                               if (!of_property_read_u32(np_cpu, "reg", &id)) {
>> +                                       if (id == cpu_logical_map(0))
>> +                                               is_allowed = true;
>
> You can do "of_node_put(np_cpu); break;" here, to stop scanning.

Yes, that's correct. I did not manage to get this update into the V2
series but will do later on in V3.

Thanks!

/ magnus