Re: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.

[Suman Tripathi <stripathi@apm.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1805 bytes --]

Hi Arnd,

On Wed, May 6, 2015 at 5:27 PM, Suman Tripathi <stripathi@apm.com> wrote:

>
>
> On Wed, May 6, 2015 at 2:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
>> On Wednesday 06 May 2015 09:45:15 Michal Simek wrote:
>> > On 05/06/2015 09:31 AM, Arnd Bergmann wrote:
>> > > On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote:
>> > >>>> @@ -533,6 +567,16 @@
>> > >>>>                         interrupts = <0x0 0x4f 0x4>;
>> > >>>>                 };
>> > >>>>
>> > >>>> +               sdhc0: sdhc@1c000000 {
>> > >>>> +                       device_type = "sdhc";
>> > >>>
>> > >>> device_type generally should not be used (there are a few
>> exceptions).
>> > >>
>> > >> Okay !!
>> > >>
>> > >
>> > > While we're at it, please change sdhc@1c000000 to mmc@1c000000.
>> > > Even though Linux does not care, we try to use the standard device
>> > > names for consistency.
>> >
>> > Do we have a list of these names somewhere?
>> > Normally I do use ePARP - generic names recommendation but mmc or sdhci
>> > are not listed there.
>> > Both combination mmc@ or sdhci@ are used in the kernel.
>> >
>> > On zynq and zynqmp we do use shdci@.
>> >
>>
>> Ah, I thought ePAPR listed mmc already. Using "sdhci" is a little too
>> specific here, since a lot of mmc hosts are not sdhci compliant, and
>> "sdhc" is completely wrong, because that identifies a specific card
>> type, but a host that supports SDHC cards will generally also work
>> with SD (less than 4GB) or SDXC (more than 48GB) cards.
>>
>
> Agree on this . Will change it.
>

One more point as we are resuing the arasan driver,  is it compulsory to
use the name used in binding info
for arasan ?? It is sdhci for arasan.


>
>>         Arnd
>>
>
>
>
> --
> Thanks,
> with regards,
> Suman Tripathi
>



-- 
Thanks,
with regards,
Suman Tripathi

[-- Attachment #1.2: Type: text/html, Size: 3416 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev