From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suman Tripathi Subject: Re: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. Date: Wed, 6 May 2015 17:31:32 +0530 Message-ID: References: <1430817426-5241-1-git-send-email-stripathi@apm.com> <4635229.bceBxngCoe@wuerfel> <5549C68B.9090602@xilinx.com> <2568634.iEosTvMJpM@wuerfel> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7875508870032335182==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Arnd Bergmann Cc: "devicetree@vger.kernel.org" , Mark Langsdorf , "jcm@redhat.com" , Anton Vorontsov , "linux-mmc@vger.kernel.org" , Michal Simek , "chris@printf.net" , "patches@apm.com" , Rob Herring , Don Dutile , linuxppc-dev , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org --===============7875508870032335182== Content-Type: multipart/alternative; boundary=047d7ba97f1a55651d0515688ec3 --047d7ba97f1a55651d0515688ec3 Content-Type: text/plain; charset=UTF-8 Hi Arnd, On Wed, May 6, 2015 at 5:27 PM, Suman Tripathi wrote: > > > On Wed, May 6, 2015 at 2:10 PM, Arnd Bergmann wrote: > >> On Wednesday 06 May 2015 09:45:15 Michal Simek wrote: >> > On 05/06/2015 09:31 AM, Arnd Bergmann wrote: >> > > On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote: >> > >>>> @@ -533,6 +567,16 @@ >> > >>>> interrupts = <0x0 0x4f 0x4>; >> > >>>> }; >> > >>>> >> > >>>> + sdhc0: sdhc@1c000000 { >> > >>>> + device_type = "sdhc"; >> > >>> >> > >>> device_type generally should not be used (there are a few >> exceptions). >> > >> >> > >> Okay !! >> > >> >> > > >> > > While we're at it, please change sdhc@1c000000 to mmc@1c000000. >> > > Even though Linux does not care, we try to use the standard device >> > > names for consistency. >> > >> > Do we have a list of these names somewhere? >> > Normally I do use ePARP - generic names recommendation but mmc or sdhci >> > are not listed there. >> > Both combination mmc@ or sdhci@ are used in the kernel. >> > >> > On zynq and zynqmp we do use shdci@. >> > >> >> Ah, I thought ePAPR listed mmc already. Using "sdhci" is a little too >> specific here, since a lot of mmc hosts are not sdhci compliant, and >> "sdhc" is completely wrong, because that identifies a specific card >> type, but a host that supports SDHC cards will generally also work >> with SD (less than 4GB) or SDXC (more than 48GB) cards. >> > > Agree on this . Will change it. > One more point as we are resuing the arasan driver, is it compulsory to use the name used in binding info for arasan ?? It is sdhci for arasan. > >> Arnd >> > > > > -- > Thanks, > with regards, > Suman Tripathi > -- Thanks, with regards, Suman Tripathi --047d7ba97f1a55651d0515688ec3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Arnd,

On Wed, May 6, 2015 at 5:27 PM, Suman Tripathi <stripathi@apm.= com> wrote:


On Wed, May 6, 2015 at 2:10 PM, Arnd Bergmann <arnd@arndb.de&g= t; wrote:
On Wednesday 0= 6 May 2015 09:45:15 Michal Simek wrote:
> On 05/06/2015 09:31 AM, Arnd Bergmann wrote:
> > On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote:
> >>>> @@ -533,6 +567,16 @@
> >>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0interrupts =3D <0x0 0x4f 0x4>;<= br> > >>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0};
> >>>>
> >>>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0sdhc0: sdhc@1c000000 {
> >>>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0device_type =3D "sdhc";
> >>>
> >>> device_type generally should not be used (there are a few= exceptions).
> >>
> >> Okay !!
> >>
> >
> > While we're at it, please change sdhc@1c000000 to mmc@1c00000= 0.
> > Even though Linux does not care, we try to use the standard devic= e
> > names for consistency.
>
> Do we have a list of these names somewhere?
> Normally I do use ePARP - generic names recommendation but mmc or sdhc= i
> are not listed there.
> Both combination mmc@ or sdhci@ are used in the kernel.
>
> On zynq and zynqmp we do use shdci@.
>

Ah, I thought ePAPR listed mmc already. Using "sdhci"= is a little too
specific here, since a lot of mmc hosts are not sdhci compliant, and
"sdhc" is completely wrong, because that identifies a specific ca= rd
type, but a host that supports SDHC cards will generally also work
with SD (less than 4GB) or SDXC (more than 48GB) cards.

Agree on this . Will change it. =C2=A0

One more point as we are r= esuing the arasan driver, =C2=A0is it compulsory to use the name used in bi= nding info
for arasan ?? It is sdhci for arasan.=C2=A0
= =C2=A0

=C2=A0 =C2=A0 =C2=A0 =C2=A0 Arnd



--
Thanks,
with regard= s,
Suman Tripathi



--
Thanks,
with regards,<= /div>Suman Tripathi
--047d7ba97f1a55651d0515688ec3-- --===============7875508870032335182== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMt ZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xp c3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2 --===============7875508870032335182==--