From: Fabio Estevam <festevam@gmail.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] dts: arm64: imx8dxl-evk: add lpuart1 and cm40 uart
Date: Wed, 28 Feb 2024 17:04:54 -0300 [thread overview]
Message-ID: <CAOMZO5A0iNpU702DBEyPgkHyOR6M-xDkw9SQTxiFQK65Af79yw@mail.gmail.com> (raw)
In-Reply-To: <20240228-m4_lpuart-v1-4-9e6947be15e7@nxp.com>
On Wed, Feb 28, 2024 at 4:55 PM Frank Li <Frank.Li@nxp.com> wrote:
> + modem_reset: modem-reset {
> + compatible = "gpio-reset";
I don't see this compatible documented.
> + reset-gpios = <&pca6416_2 0 GPIO_ACTIVE_LOW>;
> + reset-delay-us = <2000>;
> + reset-post-delay-ms = <40>;
> + #reset-cells = <0>;
> + };
> +
> + m2_uart1_sel: fixedregulator@101 {
Why is this @101 here? You should remove it.
Passing a unit address without a corresponding reg entry triggers a
dt-schema warning.
We want less warnings dt-schema warnings, not more :-)
next prev parent reply other threads:[~2024-02-28 20:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 19:54 [PATCH 0/4] arm64: dts: imx8: add cm40 and cm40_uart Frank Li
2024-02-28 19:54 ` [PATCH 1/4] arm64: dts: imx8: add cm40 subsystem dtsi Frank Li
2024-02-29 10:08 ` Alexander Stein
2024-02-28 19:54 ` [PATCH 2/4] arm64: dts: imx8dxl: add lpuart device in cm40 subsystem Frank Li
2024-02-28 20:05 ` Fabio Estevam
2024-02-29 10:12 ` Alexander Stein
2024-02-28 19:54 ` [PATCH 3/4] arm64: dts: imx8dxl: update cm40 irq number informaiton Frank Li
2024-02-28 19:55 ` [PATCH 4/4] dts: arm64: imx8dxl-evk: add lpuart1 and cm40 uart Frank Li
2024-02-28 20:04 ` Fabio Estevam [this message]
2024-02-29 13:35 ` [PATCH 0/4] arm64: dts: imx8: add cm40 and cm40_uart Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5A0iNpU702DBEyPgkHyOR6M-xDkw9SQTxiFQK65Af79yw@mail.gmail.com \
--to=festevam@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).