Re: [PATCH v7 1/3] dt-bindings: thermal-zones: Document critical-action

[Fabio Estevam <festevam@gmail.com>]

Hi Amit and Daniel,

On Fri, Sep 8, 2023 at 3:02 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Fri, Sep 8, 2023 at 7:37 PM Fabio Estevam <festevam@denx.de> wrote:
> >
> > Hi Rafael,
> >
> > On 07/09/2023 13:23, Rafael J. Wysocki wrote:
> >
> > > So one more question here: Why is this a property of a thermal zone
> > > and not the property of the whole system?
> > >
> > > Presumably, on a system where the platform integrator prefers to
> > > reboot on critical temperature, it would be necessary to add this
> > > property to every thermal zone.
> > >
> > > Also, what if this property has different values for different thermal
> > > zones?
> >
> > I got your point and I can make the 'critical-action' property to be
> > valid
> > for the whole thermal system.
> >
> > Originally, I have been doing like this:
> >
> >         thermal-zones {
> >                 cpu-thermal {
> >                         critical-action = "reboot";
> >                         polling-delay-passive = <250>;
> >                         polling-delay = <2000>;
> >                         thermal-sensors = <&tmu>;
> >
> >                         trips {
> >                                 cpu_alert0: trip0 {
> >                                         temperature = <85000>;
> >                                         hysteresis = <2000>;
> >                                         type = "passive";
> >                                 };
> >
> > I can change it to be:
> >
> >
> >         thermal-zones {
> >                 critical-action = "reboot";
> >
> >                 cpu-thermal {
> >                         polling-delay-passive = <250>;
> >                         polling-delay = <2000>;
> >                         thermal-sensors = <&tmu>;
> >
> >                         trips {
> >                                 cpu_alert0: trip0 {
> >                                         temperature = <85000>;
> >                                         hysteresis = <2000>;
> >                                         type = "passive";
> >                                 };
> >
>
> I think that this would match the use case better.
>
> I still would love to hear about it from the people who take care of
> the DT-based thermal control (mostly Daniel and Amit, who BTW is
> listed as the maintainer of the file being updated by this patch),
> though.

Please let us know what you think.

I can send v8 which places the 'critical-action' property to be valid
for the whole thermal system, as suggested by Rafael.

Thanks