From: Fabio Estevam <festevam@gmail.com>
To: Martyn Welch <martyn.welch@collabora.co.uk>
Cc: Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD
Date: Wed, 12 Jul 2017 09:34:19 -0300 [thread overview]
Message-ID: <CAOMZO5APZNVFNz2ZHnWo15mzkZ7XpP-HyPgJKs1jootN3WM=HQ@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5D6xw4hVCOWfM0+++PQ87xBwihGSCJZsW8qBdn==vrLvA@mail.gmail.com>
On Wed, Jul 12, 2017 at 9:32 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Jul 11, 2017 at 10:42 AM, Martyn Welch
> <martyn.welch@collabora.co.uk> wrote:
>
>> Changes since PATCHv3: https://patchwork.kernel.org/patch/9819017/
>> - licensing modified
>> - manufacturer changed to GE
>> - regulator nodes corrected
>> - backlight node corrected
>> - flags rather than magic numbers used
>> - registers for usbphys added
>> - set up IOMUX configuration correctly
>> - various whitespace corrections
>> - removed unused fsl,mode node
>
> Actually I still see 'fsl,mode' under the ssi2 node. Please remove it.
>
>> +#define I2C_PAD_CTL 0xc0000000
>
> This still sets bits 31, which means the kernel will rely on the IOMUX
> configuration from the bootloader.
>
> It is better if you could just pass the real IOMUX values here instead.
And please also fix the typo on the
linux-arm-kernel@lists.infradead.org address next time :-)
prev parent reply other threads:[~2017-07-12 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 13:42 [PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD Martyn Welch
[not found] ` <cffaa6f22474ff2ba4ca46d4252d35fc75cb0dd7.1499779628.git.martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2017-07-12 12:32 ` Fabio Estevam
2017-07-12 12:34 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5APZNVFNz2ZHnWo15mzkZ7XpP-HyPgJKs1jootN3WM=HQ@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fabien.lahoudere@collabora.co.uk \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martyn.welch@collabora.co.uk \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).