devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] ARM: dts: ccimx6ulsbcpro: Add 10" AUO/Goodix LVDS panel accessory kit
@ 2018-10-22 10:33 Alex Gonzalez
  2018-10-22 10:33 ` [PATCH 1/2] ARM: dts: ccimx6ulsbcpro: Add support for AUO G101EVN010 display Alex Gonzalez
  2018-10-22 10:33 ` [PATCH 2/2] ARM: dts: ccimx6ulsbcpro: Add support for Goodix touch controller Alex Gonzalez
  0 siblings, 2 replies; 5+ messages in thread
From: Alex Gonzalez @ 2018-10-22 10:33 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, mark.rutland, s.hauer, kernel, fabio.estevam, linux-imx,
	devicetree, linux-kernel, linux-arm-kernel, alex.gonzalez

Add support for a LVDS panel accessory kit consisting of:

* AU Optronics G101EVN010 10.1 inches TFT-LCD display
* Goodix GT911 capacitive touch controller

Alex Gonzalez (2):
  ARM: dts: ccimx6ulsbcpro: Add support for AUO G101EVN010 display
  ARM: dts: ccimx6ulsbcpro: Add support for Goodix touch controller

 arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts | 44 +++++++++++++++++++++++++++++
 arch/arm/configs/imx_v6_v7_defconfig        |  1 +
 2 files changed, 45 insertions(+)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] ARM: dts: ccimx6ulsbcpro: Add support for AUO G101EVN010 display
  2018-10-22 10:33 [PATCH 0/2] ARM: dts: ccimx6ulsbcpro: Add 10" AUO/Goodix LVDS panel accessory kit Alex Gonzalez
@ 2018-10-22 10:33 ` Alex Gonzalez
  2018-10-22 12:35   ` Fabio Estevam
  2018-10-22 10:33 ` [PATCH 2/2] ARM: dts: ccimx6ulsbcpro: Add support for Goodix touch controller Alex Gonzalez
  1 sibling, 1 reply; 5+ messages in thread
From: Alex Gonzalez @ 2018-10-22 10:33 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, mark.rutland, s.hauer, kernel, fabio.estevam, linux-imx,
	devicetree, linux-kernel, linux-arm-kernel, alex.gonzalez

Signed-off-by: Alex Gonzalez <alex.gonzalez@digi.com>
---
 arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts b/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts
index 11966d12af76..ac9ae4ac77ba 100644
--- a/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts
+++ b/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts
@@ -111,7 +111,32 @@
 		     &pinctrl_lcdif_clken
 		     &pinctrl_lcdif_hvsync>;
 	lcd-supply = <&ldo4_ext>;       /* BU90T82 LVDS bridge power */
+	display = <&g101evn010>;
 	status = "okay";
+
+	g101evn010: display@0 {
+		bits-per-pixel = <16>;
+		bus-width = <18>;
+
+		display-timings {
+			native-mode = <&timing0>;
+			timing0: timing0 {
+				clock-frequency = <68930000>;
+				hactive = <1280>;
+				vactive = <800>;
+				hfront-porch = <120>;
+				hback-porch = <0>;
+				hsync-len = <8>;
+				vback-porch = <10>;
+				vfront-porch = <0>;
+				vsync-len = <6>;
+				hsync-active = <1>;
+				vsync-active = <1>;
+				de-active = <1>;
+				pixelclk-active = <0>;
+			};
+		};
+	};
 };
 
 &ldo4_ext {

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ARM: dts: ccimx6ulsbcpro: Add support for Goodix touch controller
  2018-10-22 10:33 [PATCH 0/2] ARM: dts: ccimx6ulsbcpro: Add 10" AUO/Goodix LVDS panel accessory kit Alex Gonzalez
  2018-10-22 10:33 ` [PATCH 1/2] ARM: dts: ccimx6ulsbcpro: Add support for AUO G101EVN010 display Alex Gonzalez
@ 2018-10-22 10:33 ` Alex Gonzalez
  2018-10-22 12:36   ` Fabio Estevam
  1 sibling, 1 reply; 5+ messages in thread
From: Alex Gonzalez @ 2018-10-22 10:33 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, mark.rutland, s.hauer, kernel, fabio.estevam, linux-imx,
	devicetree, linux-kernel, linux-arm-kernel, alex.gonzalez

Signed-off-by: Alex Gonzalez <alex.gonzalez@digi.com>
---
 arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts | 19 +++++++++++++++++++
 arch/arm/configs/imx_v6_v7_defconfig        |  1 +
 2 files changed, 20 insertions(+)

diff --git a/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts b/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts
index ac9ae4ac77ba..2e7927930d4f 100644
--- a/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts
+++ b/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts
@@ -105,6 +105,19 @@
 	};
 };
 
+&i2c1 {
+	touchscreen@14 {
+		compatible = "goodix,gt911";
+		reg = <0x14>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_goodix_touch>;
+		interrupt-parent = <&gpio5>;
+		interrupts = <2 IRQ_TYPE_EDGE_RISING>;
+		irq-gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>;
+		status = "okay";
+	};
+};
+
 &lcdif {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_lcdif_dat0_17
@@ -297,6 +310,12 @@
 		>;
 	};
 
+	pinctrl_goodix_touch: goodixgrp{
+		fsl,pins = <
+			MX6UL_PAD_SNVS_TAMPER2__GPIO5_IO02	0x1020
+		>;
+	};
+
 	pinctrl_lcdif_dat0_17: lcdifdatgrp0-17 {
 		fsl,pins = <
 			MX6UL_PAD_LCD_DATA00__LCDIF_DATA00	0x79
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 7eca43ff69bb..d6e947307d67 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -170,6 +170,7 @@ CONFIG_MOUSE_PS2_ELANTECH=y
 CONFIG_INPUT_TOUCHSCREEN=y
 CONFIG_TOUCHSCREEN_ADS7846=y
 CONFIG_TOUCHSCREEN_EGALAX=y
+CONFIG_TOUCHSCREEN_GOODIX=y
 CONFIG_TOUCHSCREEN_MAX11801=y
 CONFIG_TOUCHSCREEN_IMX6UL_TSC=y
 CONFIG_TOUCHSCREEN_EDT_FT5X06=y

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: dts: ccimx6ulsbcpro: Add support for AUO G101EVN010 display
  2018-10-22 10:33 ` [PATCH 1/2] ARM: dts: ccimx6ulsbcpro: Add support for AUO G101EVN010 display Alex Gonzalez
@ 2018-10-22 12:35   ` Fabio Estevam
  0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-10-22 12:35 UTC (permalink / raw)
  To: Gonzalez, Alex
  Cc: Shawn Guo, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Sascha Hauer, linux-kernel, Rob Herring, NXP Linux Team,
	Sascha Hauer, Fabio Estevam,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Alex,

On Mon, Oct 22, 2018 at 7:34 AM Alex Gonzalez <alex.gonzalez@digi.com> wrote:

> +       g101evn010: display@0 {
> +               bits-per-pixel = <16>;
> +               bus-width = <18>;
> +
> +               display-timings {
> +                       native-mode = <&timing0>;
> +                       timing0: timing0 {
> +                               clock-frequency = <68930000>;
> +                               hactive = <1280>;
> +                               vactive = <800>;
> +                               hfront-porch = <120>;
> +                               hback-porch = <0>;
> +                               hsync-len = <8>;
> +                               vback-porch = <10>;
> +                               vfront-porch = <0>;
> +                               vsync-len = <6>;
> +                               hsync-active = <1>;
> +                               vsync-active = <1>;
> +                               de-active = <1>;
> +                               pixelclk-active = <0>;

The recommendation is not to put the panel timings in the dts file anymore.

You could add an entry for this panel into the simple-panel driver and
then reference its compatible string in the board dts.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] ARM: dts: ccimx6ulsbcpro: Add support for Goodix touch controller
  2018-10-22 10:33 ` [PATCH 2/2] ARM: dts: ccimx6ulsbcpro: Add support for Goodix touch controller Alex Gonzalez
@ 2018-10-22 12:36   ` Fabio Estevam
  0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-10-22 12:36 UTC (permalink / raw)
  To: Gonzalez, Alex
  Cc: Shawn Guo, Rob Herring, Mark Rutland, Sascha Hauer, Sascha Hauer,
	Fabio Estevam, NXP Linux Team,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

On Mon, Oct 22, 2018 at 7:34 AM Alex Gonzalez <alex.gonzalez@digi.com> wrote:

Please add a commit log.

> Signed-off-by: Alex Gonzalez <alex.gonzalez@digi.com>
> ---
>  arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts | 19 +++++++++++++++++++
>  arch/arm/configs/imx_v6_v7_defconfig        |  1 +

Please split this into two patches: one for the dts and other for the
defconfig change, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-10-22 12:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-22 10:33 [PATCH 0/2] ARM: dts: ccimx6ulsbcpro: Add 10" AUO/Goodix LVDS panel accessory kit Alex Gonzalez
2018-10-22 10:33 ` [PATCH 1/2] ARM: dts: ccimx6ulsbcpro: Add support for AUO G101EVN010 display Alex Gonzalez
2018-10-22 12:35   ` Fabio Estevam
2018-10-22 10:33 ` [PATCH 2/2] ARM: dts: ccimx6ulsbcpro: Add support for Goodix touch controller Alex Gonzalez
2018-10-22 12:36   ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).