devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Frank Li <frank.li@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"lznuaa@gmail.com" <lznuaa@gmail.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/4] arm64: dts: imx8qxp: added ddr performance monitor nodes
Date: Tue, 12 Feb 2019 19:04:13 -0200	[thread overview]
Message-ID: <CAOMZO5AtXz8Gyh6yBzVWWiKfSVVtSAArd52LbW=a3kszZ27iOQ@mail.gmail.com> (raw)
In-Reply-To: <1550005119-25750-2-git-send-email-Frank.Li@nxp.com>

On Tue, Feb 12, 2019 at 6:59 PM Frank Li <frank.li@nxp.com> wrote:

> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 4c3dd95..243d7b3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -79,6 +79,13 @@
>                 interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
>         };
>
> +       ddr_pmu0: ddr_pmu@5c020000 {

It seems you ignored the commend I made in the previous version.

Here it goes again:

Underscores should not be used in node names. You could use
pmu@5c020000 instead.

  reply	other threads:[~2019-02-12 21:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12 20:58 [PATCH V2 1/4] drivers/perf: imx_ddr: Add ddr performance counter support Frank Li
2019-02-12 20:58 ` [PATCH V2 2/4] arm64: dts: imx8qxp: added ddr performance monitor nodes Frank Li
2019-02-12 21:04   ` Fabio Estevam [this message]
2019-02-12 21:08     ` Zhi Li
2019-02-12 20:59 ` [PATCH V2 3/4] dt-bindings: perf: imx8-ddr: add imx8qxp ddr performance monitor Frank Li
2019-02-12 21:05   ` Fabio Estevam
2019-02-12 20:59 ` [PATCH V2 4/4] MAINTAINERS: Added imx DDR performonitor driver maintainer information Frank Li
2019-02-13  2:03 ` [PATCH V2 1/4] drivers/perf: imx_ddr: Add ddr performance counter support Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5AtXz8Gyh6yBzVWWiKfSVVtSAArd52LbW=a3kszZ27iOQ@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frank.li@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=lznuaa@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).