devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Alexander Kurz <akurz@blala.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] ARM: dts: imx6 wandboard and riotboard: remove regulators bus node
Date: Sun, 27 May 2018 13:40:13 -0300	[thread overview]
Message-ID: <CAOMZO5AzC1FVfwuimxnaGgsksDk6MjXpGiwwbc0Yer-fX8ZVFA@mail.gmail.com> (raw)
In-Reply-To: <20180526183053.14029-2-akurz@blala.de>

Hi Alexander,

[It would be better to split this patch in two: one for wandboard and
another one for riotboard]

On Sat, May 26, 2018 at 3:30 PM, Alexander Kurz <akurz@blala.de> wrote:

> +
> +       reg_2p5v: fixedregulator@0 {

This causes dtc warnings with W=1 as you are passing a unit address
without a corresponding reg property.

You can rewrite this as:

reg_2p5v: regulator-2p5v {

Please follow this convention in the entire series.

Thanks

  reply	other threads:[~2018-05-27 16:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-26 18:30 ARM: dts: imx6: enable OTG on wandboard and riotboard Alexander Kurz
2018-05-26 18:30 ` [PATCH 1/3] ARM: dts: imx6 wandboard and riotboard: remove regulators bus node Alexander Kurz
2018-05-27 16:40   ` Fabio Estevam [this message]
2018-05-28  0:56   ` Fabio Estevam
2018-05-26 18:30 ` [PATCH 2/3] ARM: dts: imx6qdl-wandboard: enable USB OTG Alexander Kurz
2018-05-26 18:30 ` [PATCH 3/3] ARM: dts: imx6dl-riotboard: fix OTG regulator polarity Alexander Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5AzC1FVfwuimxnaGgsksDk6MjXpGiwwbc0Yer-fX8ZVFA@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=akurz@blala.de \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).