From: Fabio Estevam <festevam@gmail.com>
To: Marco Antonio Franchi <marco.franchi@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"marcofrk@gmail.com" <marcofrk@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"atv@google.com" <atv@google.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: freescale: add initial support for Google i.MX 8MQ Phanbell
Date: Thu, 21 Nov 2019 15:22:36 -0300 [thread overview]
Message-ID: <CAOMZO5ByMkp1i=rMScgadT9_ucnsxqn_pnSP4bmLUPnxPdYHvw@mail.gmail.com> (raw)
In-Reply-To: <20191121162520.10120-2-marco.franchi@nxp.com>
Hi Marco,
On Thu, Nov 21, 2019 at 1:25 PM Marco Antonio Franchi
<marco.franchi@nxp.com> wrote:
>
> This patch adds the device tree to support Google Coral Edge TPU,
> historicaly named as fsl-imx8mq-phanbell, a computer on module
> which can be used for AI/ML propose.
>
> It introduces a minimal enablement support for this module and
> was totally based on the NXP i.MX 8MQ EVK board and i.MX 8MQ Phanbell
Please remove the "totally based on the NXP i.MX 8MQ EVK board" as
they are different boards.
> + memory@40000000 {
> + device_type = "memory";
> + reg = <0x00000000 0x40000000 0 0xc0000000>;
The memory size here does not match with the one used in the Google repo.
With these changes you can add:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
next prev parent reply other threads:[~2019-11-21 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 16:25 [PATCH v2 1/2] dt-bindings: arm: Add Google Coral Edge TPU entry Marco Antonio Franchi
2019-11-21 16:25 ` [PATCH v2 2/2] arm64: dts: freescale: add initial support for Google i.MX 8MQ Phanbell Marco Antonio Franchi
2019-11-21 18:22 ` Fabio Estevam [this message]
2019-11-22 11:56 ` Marco Franchi
2019-11-21 18:19 ` [PATCH v2 1/2] dt-bindings: arm: Add Google Coral Edge TPU entry Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5ByMkp1i=rMScgadT9_ucnsxqn_pnSP4bmLUPnxPdYHvw@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=atv@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.franchi@nxp.com \
--cc=marcofrk@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).