From: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] pwm: imx: Allow keeping the PWM active during suspend
Date: Mon, 20 Nov 2017 20:41:06 -0200 [thread overview]
Message-ID: <CAOMZO5CDyY4efCYQ+0Z4EohHwWaK1MSrX5LP7AZ9ZYC4fRAVyQ@mail.gmail.com> (raw)
In-Reply-To: <20171120211932.ro3ybgo6ih2542m2@rob-hp-laptop>
On Mon, Nov 20, 2017 at 7:19 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> Seems to me the default behavior should be LEDs are off in suspend and
> you'd add a property to enable them if desired.
>
> You problem to me sounds like something that should be fixed in the pwm
> and/or pwm-led drivers.
pwm-leds does set brightness to 0 in suspend and the fix here is to
make pwm-imx active during suspend, so that when pwm-leds sets the
brightness to 0, then pwm-imx really goes to logic level 1.
Please note that on imx6qdl-cuboxi the pwm is active low.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-20 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 14:36 [PATCH v2] pwm: imx: Allow keeping the PWM active during suspend Fabio Estevam
[not found] ` <1511015768-14140-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-20 21:19 ` Rob Herring
2017-11-20 22:41 ` Fabio Estevam [this message]
2017-11-20 23:06 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5CDyY4efCYQ+0Z4EohHwWaK1MSrX5LP7AZ9ZYC4fRAVyQ@mail.gmail.com \
--to=festevam-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).