From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB383C2D0ED for ; Mon, 30 Mar 2020 11:49:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A11AC2072E for ; Mon, 30 Mar 2020 11:49:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nsExSjXH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729855AbgC3Ltc (ORCPT ); Mon, 30 Mar 2020 07:49:32 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:44415 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729669AbgC3Ltb (ORCPT ); Mon, 30 Mar 2020 07:49:31 -0400 Received: by mail-lj1-f194.google.com with SMTP id p14so17689671lji.11; Mon, 30 Mar 2020 04:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3LI716UXF6bfo4VYqoP3VeDTvzHtXiCh3tM1tgh2v+k=; b=nsExSjXHqIvgbyHEhZzSlHZ6qD7wnb3b7lQ2UUHlFb5MZvlWcVzdj0RPl6mpt8ALgm lr8frOmesionfQ+vaY8rFIX8GvC8Q7ZgFYyxVx1tlnkK8QSOZPHwLZ/2A+Zbwa2KICUA g9VnqDbo0OoQPSqFcQsSYwvzTEzLmQlPT6RyfE5yy6S3DEVF/X8MOTnUv1G5iBt/D9M5 Xuy8PBJUBLjxWgO0vVHF69ZxuHLj13gwdEuSc3LZcVW5XIK3hJkUaWz9lZ54g7h7D+jG oSxXr/rvj7FpRtkUM4BALSUJbOlZX1oJH0VblPEPkpwEyAfpIGByujN/jXC47U8bS0cz q4fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3LI716UXF6bfo4VYqoP3VeDTvzHtXiCh3tM1tgh2v+k=; b=ANn4/7jl/xWSRvmMPiZyNiEjR5nEZC6jzLz3QZwuh2DBczH7xvPcBBAJOnf1IXLCag X6R/RD7S2RQYIPJ6In00jFn1UeUPR6m0Xqr4nbAek3J+AEU6T0fBjAgTgbgzEGDOR852 rjQcRES+moN6XmX3mG/clgWczc1F4+LUF27SnayQZ3kbTfGw0pM+rV80rzR3KdwM/Mw7 UyqNR8+1vIp+amgo7ANgP8RGYnyr4ftxyzYnFdkXHU+cPvJJoF+AxKBzUtUz1zrqSiJw a5PVL68IZKr2QS6uIy7y3loGlUWH6Us8EqxpxBDQTBnbHcFQWXI4uJAPS6ulmrDw85Is J4aA== X-Gm-Message-State: AGi0PubinbOuFsCjq4L8tnh6CM3BI2w8R0usVbc/Dik1IOnfqRCJEIt1 oaB4Aa1IcJfDNq7CgoWJymv2roIrcpe0dEMvBSI= X-Google-Smtp-Source: APiQypJcW+KgRk6o/Ou48vwV4luc+5i+/EZubfDgsinD6eEi6d3RUluGeVWMrjQtxj/UdvutLn1NA3q5aclTGJP/Ah4= X-Received: by 2002:a05:651c:30b:: with SMTP id a11mr6771326ljp.164.1585568968812; Mon, 30 Mar 2020 04:49:28 -0700 (PDT) MIME-Version: 1.0 References: <20200330113542.181752-1-adrian.ratiu@collabora.com> <20200330113542.181752-5-adrian.ratiu@collabora.com> In-Reply-To: <20200330113542.181752-5-adrian.ratiu@collabora.com> From: Fabio Estevam Date: Mon, 30 Mar 2020 08:49:19 -0300 Message-ID: Subject: Re: [PATCH v5 4/5] drm: imx: Add i.MX 6 MIPI DSI host platform driver To: Adrian Ratiu Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-stm32@st-md-mailman.stormreply.com, linux-rockchip@lists.infradead.org, DRI mailing list , linux-kernel , NXP Linux Team , kernel@collabora.com, Andrzej Hajda , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Emil Velikov , Sjoerd Simons , Martyn Welch Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Adrian, On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu wrote: > > This adds support for the Synopsis DesignWare MIPI DSI v1.01 host > controller which is embedded in i.MX 6 SoCs. > > Based on following patches, but updated/extended to work with existing > support found in the kernel: > > - drm: imx: Support Synopsys DesignWare MIPI DSI host controller > Signed-off-by: Liu Ying > > - ARM: dtsi: imx6qdl: Add support for MIPI DSI host controller > Signed-off-by: Liu Ying This one looks like a devicetree patch, but this patch does not touch devicetree. > + ret = clk_prepare_enable(dsi->pllref_clk); > + if (ret) { > + dev_err(dev, "%s: Failed to enable pllref_clk\n", __func__); > + return ret; > + } > + > + dsi->mux_sel = syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,gpr"); > + if (IS_ERR(dsi->mux_sel)) { > + ret = PTR_ERR(dsi->mux_sel); > + dev_err(dev, "%s: Failed to get GPR regmap: %d\n", > + __func__, ret); > + return ret; You should disable the dsi->pllref_clk clock prior to returning the error. > + dsi->mipi_dsi = dw_mipi_dsi_probe(pdev, pdata); > + if (IS_ERR(dsi->mipi_dsi)) { > + ret = PTR_ERR(dsi->mipi_dsi); > + dev_dbg(dev, "%s: Unable to probe DW DSI host device: %d\n", > + __func__, ret); > + return -ENODEV; Same here. You should disable the clock. Shouldn't you return 'ret' here instead of -ENODEV? > +module_platform_driver(imx_mipi_dsi_driver); > + > +MODULE_DESCRIPTION("i.MX6 MIPI DSI host controller driver"); > +MODULE_AUTHOR("Liu Ying "); The freescale.com domain is no longer functional. Ying Liu's NXP address is victor.liu@nxp.com. You could probably add your entry as well.