Re: [PATCH v2 3/3] ARM: i.MX1 clk: Add devicetree support

[Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Tue, May 13, 2014 at 1:24 PM, Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org> wrote:
> Tue, 13 May 2014 13:18:40 -0300 от Fabio Estevam <festevam@gmail.com>:
>> On Tue, May 13, 2014 at 1:05 PM, Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org> wrote:
>>
>> > +       clk[IMX1_CLK_DUMMY] =
>> > +               imx_clk_fixed("dummy", 0);
>> > +       clk[IMX1_CLK_CLK32] =
>> > +               imx_obtain_fixed_clock("clk32", fref);
>> > +       clk[IMX1_CLK_CLK16M_EXT] =
>> > +               imx_clk_fixed("clk16m_ext", 16000000);
>> > +       clk[IMX1_CLK_CLK16M] =
>> > +               imx_clk_gate("clk16m", "clk16m_ext", CCM_CSCR, 17);
>>
>> Why don't you put each entry into a single line instead?
>>
>> Even if it gets larger than 80 columns, it would be easier to read.
>
> I thought about it, but came to the conclusion that it is better to observe
> the kernel rules.

Do you mean checkpatch complaint?

Then try to make checkpatch happy with other clock file such as
arch/arm/mach-imx/clk-imx6q.

The result will be unreadable :-)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html